Bug 311712

check for recommended driver in SceneOpenGL2::supported might be put into an ifdef. But I think I did it that way as the environment variable is good enough. Not sure about it.

Git commit 26fdfac26b0d2a66f14f1169937c8b874cefd6d2 by Martin Gräßlin.
Committed on 20/12/2012 at 21:44.
Pushed by graesslin into branch 'KDE/4.10'.

Do not block OpenGL 2 when build for gles due to driver recommendation

Let's assume a user knows what she is doing when she selects kwin_gles
instead of kwin. Also in gles there is no fallback to OpenGL 1 possible
so blocking is not the proper solution in the first place.
FIXED-IN: 4.10 RC 2
REVIEW: 107824

M  +2    -0    kwin/scene_opengl.cpp

http://commits.kde.org/kde-workspace/26fdfac26b0d2a66f14f1169937c8b874cefd6d2

Thanks for the quick fix
Em 22/12/2012 08:45, "Martin Gräßlin" <mgraesslin@kde.org> escreveu:

> https://bugs.kde.org/show_bug.cgi?id=311712
>
> Martin Gräßlin <mgraesslin@kde.org> changed:
>
>            What    |Removed                     |Added
>
> ----------------------------------------------------------------------------
>              Status|CONFIRMED                   |RESOLVED
>    Version Fixed In|                            |4.10 RC 2
>          Resolution|---                         |FIXED
>       Latest Commit|                            |
> http://commits.kde.org/kde-
>                    |
>  |workspace/26fdfac26b0d2a66f
>                    |                            |14f1169937c8b874cefd6d2
>
> --- Comment #2 from Martin Gräßlin <mgraesslin@kde.org> ---
> Git commit 26fdfac26b0d2a66f14f1169937c8b874cefd6d2 by Martin Gräßlin.
> Committed on 20/12/2012 at 21:44.
> Pushed by graesslin into branch 'KDE/4.10'.
>
> Do not block OpenGL 2 when build for gles due to driver recommendation
>
> Let's assume a user knows what she is doing when she selects kwin_gles
> instead of kwin. Also in gles there is no fallback to OpenGL 1 possible
> so blocking is not the proper solution in the first place.
> FIXED-IN: 4.10 RC 2
> REVIEW: 107824
>
> M  +2    -0    kwin/scene_opengl.cpp
>
>
> http://commits.kde.org/kde-workspace/26fdfac26b0d2a66f14f1169937c8b874cefd6d2
>
> --
> You are receiving this mail because:
> You reported the bug.

Was this commited before RC2 came out? if so I still have the issue

"seems"

The patch will not skip the warning, but should then proceed with the GLLegcy config option processing
Do you have "opengl 2.0 shaders" activated in "kcmshell4 kwincompositing"?
You'd get a "OpenGL 2 disabled by config option" debug out for it.

please provide output of
qdbus org.kde.kwin /KWin supportInformation

that should contain all the information

aniel@bart:~/code/print-manager$ qdbus org.kde.KWin /KWin supportInformation
Informação de suporte do KWin:                                                                                                                                               
A seguinte informação deve ser usada ao pedir suporte, p.ex., no http://forum.kde.org.                                                                                       
Ela fornece informações sobre a instância atualmente em execução, quais as opções usadas,                                                                                    
qual o driver de OpenGL e os efeitos em execução.                                                                                                                            
Por favor, envie a informação oferecida abaixo deste texto introdutório para um serviço de área de transferência remoto,                                                     
tais como o http://paste.kde.org, em vez de colar o texto nos tópicos de suporte.                                                                                            
                                                                                                                                                                             
==========================                                                                                                                                                   

Options
=======
focusPolicy: 0
nextFocusPrefersMouse: false
clickRaise: true
autoRaise: false
autoRaiseInterval: 0
delayFocusInterval: 0
shadeHover: false
shadeHoverInterval: 250
separateScreenFocus: false
activeMouseScreen: false
placement: 4
focusPolicyIsReasonable: true
borderSnapZone: 10
windowSnapZone: 10
centerSnapZone: 0
snapOnlyWhenOverlapping: false
showDesktopIsMinimizeAll: false
rollOverDesktops: true
focusStealingPreventionLevel: 1
legacyFullscreenSupport: false
operationTitlebarDblClick: 
commandActiveTitlebar1: 0
commandActiveTitlebar2: 30
commandActiveTitlebar3: 2
commandInactiveTitlebar1: 4
commandInactiveTitlebar2: 30
commandInactiveTitlebar3: 2
commandWindow1: 7
commandWindow2: 8
commandWindow3: 8
commandWindowWheel: 31
commandAll1: 10
commandAll2: 3
commandAll3: 14
keyCmdAllModKey: 16777251
showGeometryTip: false
condensedTitle: false
electricBorders: false
electricBorderDelay: 150
electricBorderCooldown: 350
electricBorderPushbackPixels: 1
electricBorderMaximize: true
electricBorderTiling: true
electricBorderCornerRatio: 0.25
borderlessMaximizedWindows: false
killPingTimeout: 5000
hideUtilityWindowsForInactive: true
inactiveTabsSkipTaskbar: false
autogroupSimilarWindows: false
autogroupInForeground: true
compositingMode: 1
useCompositing: true
compositingInitialized: true
hiddenPreviews: 1
unredirectFullscreen: false
glSmoothScale: 0
glVSync: false
colorCorrected: false
xrenderSmoothScale: false
maxFpsInterval: 17
refreshRate: 0
vBlankTime: 6144
glDirect: true
glStrictBinding: true
glStrictBindingFollowsDriver: true
glLegacy: true

Compositing
===========
Qt Graphics System: native
Compositing is not active

>Do you have "opengl 2.0 shaders" activated in "kcmshell4 kwincompositing"?
No that option makes kwin_gles slower here when compositing is working...

> >Do you have "opengl 2.0 shaders" activated in "kcmshell4 kwincompositing"?
> 
> No that option makes kwin_gles slower here when compositing is working...
:-) Then I dare to say that you never had kwin_gles with OpenGL running. 
kwin_gles only operates with OpenGL 2, the OpenGl 1 code path is ifdefed.

If it has always been like that, it probably just fall back to XRender, which 
would explain why you have graphicssystem native instead of the default.

Created attachment 76455 [details]
KWin with KWIN_COMPOSE=O2

Created attachment 76456 [details]
kwin without any env var

Created attachment 76457 [details]
kwin set to xrender

>:-) Then I dare to say that you never had kwin_gles with OpenGL running. 
>kwin_gles only operates with OpenGL 2, the OpenGl 1 code path is ifdefed.
Compositing Type: OpenGL ES 2.0

sorry the first time I pasted it was with kwin without the O2 env var (I didn't know
you wanted the output of the working thing...)

Also since it worked in kde 4.9 there would still be some issue, and setting to
xrender makes another difference.

please note that all outputs where made using kwin_gles not kwin

Thanks

Please enable the OpenGL 2 shaders option and switch the graphics system to raster

Created attachment 76462 [details]
OpenGL 2 Shaders enabled and raster (dunno why I didn't set raster before :P )

>(dunno why I didn't set raster before :P
because changing to XRender automatically changes to native.

@Daniel: is now everything fine or are there still issues?

Ok, so it seems the regression is actually that in 4.9 if you didn't check "Use OpenGL 2 shaders" it enabled for you, having that checked kwin_gles runs composited, probably that checkbox wasn't reflecting the current state of the compositor?

BTW does the Raster setting there means all Qt apps will run using raster or I still need that env var?

(In reply to comment #18)
> BTW does the Raster setting there means all Qt apps will run using raster or
> I still need that env var?
no, it only affects KWin, but Qt uses raster by default nowadays.