| Summary: | THUMBBAR : wrong items selection with shift key | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Dennis Grunert <post> |
| Component: | Thumbs-BarView | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | caulier.gilles, post, skarmoutsosv |
| Priority: | NOR | ||
| Version: | 5.4.0 | ||
| Target Milestone: | --- | ||
| Platform: | openSUSE | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/digikam/98bdea2b65ddef17eb2e973f748359b3ced3555b | Version Fixed In: | 5.5.0 |
| Sentry Crash Report: | |||
|
Description
Dennis Grunert
2012-12-13 20:22:08 UTC
I remember I had a look at that problem previously, there may be an older bug report. What I recall, there is a field in QAbstractItemView which constitutes the "where your last mouseclick was". This field is in a private structure and inaccessible, meaning it's not fixed easily without rewriting considerable amounts of code. It's still there in digicam 3.1, so even if (like Marcel Wiesweg said) there needs to be a lot of code rewritten, it needs to be done. The user have trust in such a simple and common function of the UI and if it doesn't work as expected, it can have consequences that one maybe only recognize later. I for myself delete photos that way (look at them with the keyboard and then mark the subset of them, which I want to delete, with shift+mouseclick). Even with a high resolution of 1680x1050 I can only see 6 photos a once, so I only notice that I deleted way to much photos once it is too late. Likely I only deleted with del-key and not shift-del and I noticed this bug quickly, but others won't. Why is this bug not marked confirmed? Marcel Wiesweg already confirmed it's existence in his comment. This bug is one of the reason, why the amount of people with the opinion "KDE sucks" grows lager every day. KDE cannot getting to work a simple and important UI feature properly. Instead data loss is risked (I had data loss), because someone used a private instead of global structure? Somebody is willing to fix this. Where is the person, who is responsible for this wrong programing decision anyway? Com'on that all can't be true. Soon you have one person more, who buys "KDE suck" t-shirts. Denis, This file still valid using last digiKam 4.2.0 ? Gilles Caulier Sorry, I still have 3.5 installed. But I doubt that it got fixed without marking it here upstream because the problem is already known to the devs and complicated to fix. I confirm the bug with 4.3.0 Gilles Caulier This bug describes erratic selection when using spacebar at preview image. I have filed the https://bugs.kde.org/show_bug.cgi?id=341032 bug, which describes about the same problem but with the use of on screen left-right navigation arrows. I confirm this bug with digiKam 4.4.0 under Debian testing (jessie) with Gnome 3.14.1 When a bug causes implicit data loss it should be considered important. Especially in the case of digiKam which is targeted to a more professional user base, data loss should be considered 'fatal'. Vangelis Skarmousos *** Bug 341032 has been marked as a duplicate of this bug. *** This file still valid using last digiKam 5.0.0 ? Gilles Caulier What's about this file using digiKam AppImage bundle 5.4.0 pre release given at this url : https://drive.google.com/drive/folders/0BzeiVr-byqt5Y0tIRWVWelRJenM Gilles Caulier Yes, the bug is still valid with the digiKam AppImage bundle 5.4.0 pre release which you have provided. Everyone can test this easily with the steps described in the first comment. Only today, I deleted a few images by accident because of this bug. Git commit 98bdea2b65ddef17eb2e973f748359b3ced3555b by Maik Qualmann. Committed on 15/01/2017 at 09:35. Pushed by mqualmann into branch 'master'. fix syncing thumbbar selection FIXED-IN: 5.5.0 M +2 -1 NEWS M +7 -2 app/views/stackedview.cpp M +9 -11 utilities/importui/views/importstackedview.cpp https://commits.kde.org/digikam/98bdea2b65ddef17eb2e973f748359b3ced3555b |