Summary: | when using the call-ui to make a voip audio call there is no dialpad available | ||
---|---|---|---|
Product: | [Unmaintained] telepathy | Reporter: | Craig Magina <craig.magina> |
Component: | call-ui | Assignee: | Telepathy Bugs <kde-telepathy-bugs> |
Status: | RESOLVED UNMAINTAINED | ||
Severity: | normal | CC: | aalexandera, arthur, bhubbard, heri+kde, kde, lasse, mklapetek, rdieter |
Priority: | NOR | Keywords: | junior-jobs |
Version: | 0.5.1 | ||
Target Milestone: | Future | ||
Platform: | Ubuntu | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: |
Description
Craig Magina
2012-12-13 17:18:15 UTC
George - can we mark this as a junior job? I'm pretty sure I have implemented a dialpad, although I admit I have never tested it, because gabble, at least back at that time, didn't implement this interface. Perhaps there is some small bug somewhere. It should be easy to debug and fix. Yeah, it could be a JJ... Hi, I'm using telepathy-rakia-0.7.4 in an up to date Gentoo system and the problem persists. Has any attempts been made yet to fix the problem? Lars (In reply to comment #2) > I'm pretty sure I have implemented a dialpad, although I admit I have never > tested it, because gabble, at least back at that time, didn't implement this > interface. Perhaps there is some small bug somewhere. It should be easy to > debug and fix. Yeah, it could be a JJ... Not yet, sorry. [01:40] <badone> d_ed_: earlier in the debugging output I see ... ktp-call-ui(1927)/Telepathy-Qt: Channel has 2 optional interfaces: ("org.freedesktop.Telepathy.Channel.Interface.Hold", "org.freedesktop.Telepathy.Channel.Interface.DTMF") [01:43] <d_ed_> between us we've found the bug [01:43] <d_ed_> the supportsDTMF method checks if the channel has the interface org.freedesktop.Telepathy.Call1.Content.Interface.DTMF [01:44] <badone> d_ed_: ahh, not org.freedesktop.Telepathy.Channel.Interface.DTMF [01:44] <d_ed_> which connection manager is this? [01:44] <badone> d_ed_: rakia [01:46] <d_ed_> I /think/ rakia isn't ported properly to the new Call1 spec [01:46] <d_ed_> but this is more low level than we go [01:47] <badone> d_ed_: So it should be easy enough to patch supportsDTMF to check for org.freedesktop.Telepathy.Channel.Interface.DTMF ? [01:47] <d_ed_> yes, however I think that's the wrong solution [01:48] <d_ed_> I think we should be patching rakia to report DTMF on the newer bus. [01:48] * d_ed_ emphasises the "I think" heavily TODO: - Check with upstream (or George) as to what's going on with http://telepathy.freedesktop.org/spec/Call_Content_Interface_DTMF.html http://telepathy.freedesktop.org/spec/Channel_Interface_DTMF.html and whether TpQt should support both, or that ChannelInterface is legacy. There's a line in the spec: "The only part of this spec that should be used with a Call1 channel is the "InitialTones" property." Implying both are used. (In reply to comment #5) > TODO: > - Check with upstream (or George) as to what's going on with > http://telepathy.freedesktop.org/spec/Call_Content_Interface_DTMF.html > http://telepathy.freedesktop.org/spec/Channel_Interface_DTMF.html > > and whether TpQt should support both, or that ChannelInterface is legacy. > There's a line in the spec: "The only part of this spec that should be used > with a Call1 channel is the "InitialTones" property." Implying both are used. Right. My interpretation of this is that in Call1 you always send DTMF tones using the Call1.Content interface and not the Channel one. The Channel one is used only for its InitialTones property, which is a Requestable and Immutable property, i.e. you set it when you create the channel request and it never changes. This interface & property is only for immediately dialing a number using DTMF after the audio session has been established, which could be useful for programmatically going through voice menus directly from the channel request, or for programmatically dialing a number on an analog telephone line that is exported through a SIP server. So, yes, the bug is in rakia according to the spec. Dear user, unfortunately Telepathy is no longer maintained. Please migrate to another solution, e.g. for Jabber a possibility is Kaidan, for Matrix a candidate is NeoChat. |