Bug 311300

Summary: Multiple identities with the same name are not correctly handled
Product: [Applications] konversation Reporter: José Millán Soto <jmillan>
Component: generalAssignee: Travis McHenry <wordsizzle>
Status: CONFIRMED ---    
Severity: normal CC: hein, wordsizzle
Priority: NOR    
Version: 1.5-rc1   
Target Milestone: ---   
Platform: Compiled Sources   
OS: All   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description José Millán Soto 2012-12-07 12:36:37 UTC 
When multiples identities have the same name, and they are assigned to different servers, after restarting konversation all the servers will be using the same identity.

Reproducible: Always

Steps to Reproduce:
1. Create two test networks: "network1" and "network2"
2. Create a new identity for network1: Call it "test", and set both real name and nickname to "test1"
3. Create a new identity for network2: Call it "test", and set both real name and nick nameto "test2"
4. Close conversation
Actual Results:  
Both network1 and network2 are using the identity that has "test1" as nickname and real name.

Expected Results:  
Network2 should be using the identity that has "test2" as nickname and real name.
Comment 1 José Millán Soto 2012-12-07 12:45:19 UTC 
I have uploaded a proposed patch to reviewboard: https://git.reviewboard.kde.org/r/107625/
This patch does not allow the user to have multiple identities with the same name.
Comment 2 Eike Hein 2012-12-07 17:31:49 UTC 
The proper fix for this is to rewrite the load/store code for the settings to serialize a [ServerGroup]'s Identity as a reference to the correct KConfig group, similar to how it already works for [ServerGroup] -> [Server] and other associations.
Comment 3 José Millán Soto 2013-03-19 17:54:37 UTC 
A patch that takes the approach suggested in comment 2 is proposed in https://git.reviewboard.kde.org/r/109588/