| Summary: | Dolphin does not restore focus on the file view after dismissing inline-rename box with enter | ||
|---|---|---|---|
| Product: | [Applications] dolphin | Reporter: | Sandro Mani <manisandro> |
| Component: | view-engine: general | Assignee: | Dolphin Bug Assignee <dolphin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bugs.kde.org3, eugene.shalygin+bugzilla.kde, sbc_hates_spam |
| Priority: | NOR | Keywords: | regression |
| Version: | 2.1.85 | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/kde-baseapps/620f9670af432c8c7a79fd47789da1788d7d6b17 | Version Fixed In: | 4.9.5 |
| Sentry Crash Report: | |||
| Attachments: | Patch (not quite ready yet) | ||
|
Description
Sandro Mani
2012-12-05 15:10:08 UTC
Thanks for the bug report! I can confirm. Unfortunately, this bug is also in KDE 4.9.4. (In reply to comment #0) > I guess this is related to #309760 You're probably right. I'll try to find a fix ASAP. Created attachment 75645 [details] Patch (not quite ready yet) This basically reverts the last two commits to KItemListRoleEditor, https://projects.kde.org/projects/kde/kde-baseapps/repository/revisions/951cb9c35d7a9ef814b3de5b359915968da9b881 https://projects.kde.org/projects/kde/kde-baseapps/repository/revisions/3143acc084d54d43df469b54762bfa10a7050a9f It fixes the keyboard focus problem, but sometimes, when I try to reproduce the bug that the first of those commits fixed (crash when dragging text from the 'inline rename' text edit and dropping it on an entry in the Places Panel), I see the problem that the drag does not stop, and I get a crash on exit because the QDrag is destroyed in its own nested event loop. Well, actually, the drag&drop problem already exists without my patch, so that's no reason not to commit it. But I'd like to have this tested by more people - we had too many inline renaming regressions recently. I really want to get it right this time. I've filed a review request and will wait for feedback from testers before pushing the fix: https://git.reviewboard.kde.org/r/107606/ You are also invited to test it, of course :-) Thanks! - Rebuild under way Works great from what I can see! Git commit 620f9670af432c8c7a79fd47789da1788d7d6b17 by Frank Reininghaus. Committed on 07/12/2012 at 22:15. Pushed by freininghaus into branch 'KDE/4.9'. Fix keyboard focus handling after renaming items inline This reverts 951cb9c35d7a9ef814b3de5b359915968da9b881 and 3143acc084d54d43df469b54762bfa10a7050a9f, and fixes the crash caused by nested event loops by delaying the deletion of the KItemListRoleEditor until the next item is renamed inline. FIXED-IN: 4.9.5 REVIEW: 107606 M +17 -14 dolphin/src/kitemviews/kstandarditemlistwidget.cpp M +1 -0 dolphin/src/kitemviews/kstandarditemlistwidget.h M +3 -49 dolphin/src/kitemviews/private/kitemlistroleeditor.cpp M +0 -12 dolphin/src/kitemviews/private/kitemlistroleeditor.h http://commits.kde.org/kde-baseapps/620f9670af432c8c7a79fd47789da1788d7d6b17 *** Bug 311458 has been marked as a duplicate of this bug. *** *** Bug 311979 has been marked as a duplicate of this bug. *** If this bug has been fixed, then I cannot understand why I cannot get cursor response after a file rename with Dolphin. I am using Kubuntu 12.10 and KDE 4.9.90. I get the same response on two different Laptops with 12.10 and one desktop with 13.04 Alpha1. ________________________________ From: Frank Reininghaus <frank78ac@googlemail.com> To: sbc_hates_spam@yahoo.com.au Sent: Thursday, 20 December 2012 9:59 PM Subject: [Bug 311206] Dolphin does not restore focus on the file view after dismissing inline-rename box with enter https://bugs.kde.org/show_bug.cgi?id=311206 Frank Reininghaus <frank78ac@googlemail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sbc_hates_spam@yahoo.com.au --- Comment #9 from Frank Reininghaus <frank78ac@googlemail.com> --- *** Bug 311979 has been marked as a duplicate of this bug. *** (In reply to comment #10) > If this bug has been fixed, then I cannot understand why I cannot get cursor > response after a file rename with Dolphin. I am using Kubuntu 12.10 and KDE > 4.9.90. The 4.9.90 packages were made before the bug was fixed. |