| Summary: | KPhotoalbum doesn't start without mplayer2 | ||
|---|---|---|---|
| Product: | [Applications] kphotoalbum | Reporter: | Johannes Zarl-Zierl <johannes> |
| Component: | general | Assignee: | KPhotoAlbum Bugs <kpabugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | blackie, gnome |
| Priority: | NOR | ||
| Version: | GIT master | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/kphotoalbum/a397ba64fa2149a78b4e21f458e0c0723086601b | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
Johannes Zarl-Zierl
2012-12-03 21:39:09 UTC
While I in theory agree that that would be a better solution, it would complicate the KPA code substantially, meaning reduce time for other bugfixes and new features. Installing mplayer ought not to be such a big deal, IMHO I have mplayer installed, from Debian Sid repositories. KPhotoalbum insists on mplayer2. Only repository I can get that from is deb-multimedia. Given the not-always-friendly relations between Debian and Deb Multimedia, it seems rather silly to add a dependency on something NOT in standard Debian repositories. (In reply to comment #2) > I have mplayer installed, from Debian Sid repositories. KPhotoalbum insists > on mplayer2. KPhotoalbum does not insist on mplayer2. When only mplayer is installed, a message is shown advising the user that mplayer2 gives better results in some cases. You can disable the message by checking "Don't show this message again." before pressing ok. > Only repository I can get that from is deb-multimedia. Given > the not-always-friendly relations between Debian and Deb Multimedia, it > seems rather silly to add a dependency on something NOT in standard Debian > repositories. mplayer2 is part of the official debian unstable repository: http://packages.debian.org/sid/mplayer2 Git commit a397ba64fa2149a78b4e21f458e0c0723086601b by Johannes Zarl. Committed on 27/05/2013 at 00:06. Pushed by johanneszarl into branch 'master'. Run without video thumbnail/length support when mplayer is missing. When mplayer is missing, just show a messagebox advising the user to install mplayer instead of bailing out. When mplayer is not available, also don't spawn video-related background jobs. M +1 -0 BackgroundJobs/HandleVideoThumbnailRequestJob.cpp M +9 -4 DB/NewImageFinder.cpp M +6 -0 ImageManager/AsyncLoader.cpp M +20 -14 MainWindow/Window.cpp http://commits.kde.org/kphotoalbum/a397ba64fa2149a78b4e21f458e0c0723086601b |