Bug 310977

Summary:	Applying data (exif, iptc, xmp caption) in "Edit all Metadata" window inconsistent - results in data loss
Product:	[Applications] digikam	Reporter:	schuschq
Component:	Plugin-Generic-MetadataEdit	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	alan.pater, caulier.gilles, metzpinguin, schuschq
Priority:	NOR
Version:	2.9.0
Target Milestone:	---
Platform:	openSUSE
OS:	Linux
Latest Commit:	http://commits.kde.org/kipi-plugins/5e1dd153b0a8cad1abd6aa21e9ea120b876a34e5	Version Fixed In:	4.9.0
Sentry Crash Report:
Attachments:	metadataedit.patch

Description schuschq 2012-12-01 13:13:12 UTC

inconsistent handling of saving data in caption fields, see description 

Reproducible: Always

Steps to Reproduce:
1. mark some (example: 3) images in thumbnails window. The images must not have an XMP Caption!
2. choose "Image > Metadata > Edit all Metadata ..."
3. choose "Edit XMP > Content" (you are editing the first image)
4. check "Caption" box (all sync buttons not checked) - (remember: xmp caption data must be empty for all images!)
5. enter Caption (example: "blabla")
6. Apply data (only the first image edited)
7. now you can find "blabla" also in the xmp caption fields of the other images (but it was not entered there)

Actual Results:  
if there is nothing written in this field prior to the first edit, the edit is written to all images with an empty field (didn't try it with mixed empty / not empty fields).

But, if the images do have a xmp caption - this one is not overwritten. 

 (I think this happens with other fields too, but I'm not sure)

Expected Results:  
as long as I don't check a box like "[x] use information for all images", I don't expect the data to be taken for all images ...


If i've opened 3 images with empty exif, iptc and xmp caption fields
and I add an exif-caption for the first image (example "schubidu"), and check "Sync XMP caption", "Sync IPTC caption" and apply this
- I get the first image with exif-caption, iptc-caption, xmp-caption (all with "schubidu"), second and third image only with xmp-caption ... it should at least be consistent.

Comment 1 schuschq 2012-12-04 08:35:19 UTC

results in data loss

another example: viewing for example ten images to check the xmp caption shows wrong information:

Steps to Reproduce: 1. mark some (example: 3) images in thumbnails window. The first two have (different) xmp captions, the other eight have empty xmp captions
2. choose "Image > Metadata > Edit all Metadata ..."
3. choose "Edit XMP > Content" (you are editing/viewing the first image)
4. You can see the caption of the first image
5. click "Next"
4. You can see the caption of the second image
5. click "Next"
6. You should see an empty caption, because this image doesn't have one - but you see the caption of the second image
7... you see the caption of the second image for all the rest of the images ...

so you may think the images are tagged and you close the editor ... but there is no information in this tag ...

like this, the use of the metadata editor leads to unpredictable results in daily use 
-> if you need the xmp caption digikam/kipiplugins are not usable because they are not reliable!

this may also be the case for the xmp copyright field 

it gets even worse together with https://bugs.kde.org/show_bug.cgi?id=311005

can I deliver more infos to help?

Regards, Schusch

Comment 2 caulier.gilles 2014-08-28 13:35:00 UTC

Can you refresh status of this file using last digiKam 4.2.0 ?

Gilles Caulier

Comment 3 Alan Pater 2015-03-06 23:56:59 UTC

Confirmed using digikam 4.8.0 & exiv2 0.24 on Ubuntu 14.04.

Comment 4 Alan Pater 2015-03-07 00:07:14 UTC

It looks like the "Next" and "Previous" buttons do not clear the fields, they just overwrite the text IF the neighbouring image has data for that field.

Comment 5 Maik Qualmann 2015-03-11 19:35:20 UTC

Created attachment 91535 [details]
metadataedit.patch

This patch fixes the issues in the XMP editor.

Comment 6 caulier.gilles 2015-03-22 07:50:22 UTC

Git commit 5e1dd153b0a8cad1abd6aa21e9ea120b876a34e5 by Gilles Caulier.
Committed on 22/03/2015 at 07:48.
Pushed by cgilles into branch 'master'.

apply patch #91535 from Maik Qualmann t fix behavior of comment edit in MetadatEdit kipi tool
FIXED-IN: 4.9.0

M  +5    -4    metadataedit/plugin/altlangstringedit.cpp
M  +11   -0    metadataedit/xmp/xmpcontent.cpp
M  +9    -0    metadataedit/xmp/xmpstatus.cpp

http://commits.kde.org/kipi-plugins/5e1dd153b0a8cad1abd6aa21e9ea120b876a34e5

Comment 7 caulier.gilles 2015-03-22 07:56:44 UTC

Git commit ac8a2c4d011bfb93b39a538383abd72497faf594 by Gilles Caulier.
Committed on 21/03/2015 at 17:02.
Pushed by cgilles into branch 'frameworks'.

backport commit #5e1dd153b0a8cad1abd6aa21e9ea120b876a34e5 from git/master to frameworks branch

M  +5    -4    PORT.KF5/TODO/metadataedit/plugin/altlangstringedit.cpp
M  +11   -0    PORT.KF5/TODO/metadataedit/xmp/xmpcontent.cpp
M  +9    -0    PORT.KF5/TODO/metadataedit/xmp/xmpstatus.cpp

http://commits.kde.org/kipi-plugins/ac8a2c4d011bfb93b39a538383abd72497faf594