Summary: | Webslice applet doesn't resize correctly on page refresh | ||
---|---|---|---|
Product: | [Plasma] plasma4 | Reporter: | Mariusz Mazur <mariusz.g.mazur> |
Component: | widget-webslice | Assignee: | Plasma Bugs List <plasma-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | kde, mfraz74+kde |
Priority: | NOR | ||
Version: | 4.9.3 | ||
Target Milestone: | --- | ||
Platform: | Unlisted Binaries | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/kdeplasma-addons/919370eba3978f641b8e8be1f3c2e299dc9c090d | Version Fixed In: | 4.10.3 |
Attachments: |
Fix for the problem
Fix; also handles resizes |
Description
Mariusz Mazur
2012-11-29 14:01:19 UTC
Figured out the pattern. It's one zoom level after another, every other reload, so (say), 45%, 100%, 45%, 100%, 45% ad infinitum. Created attachment 75568 [details]
Fix for the problem
Attached patch fixes the problem I've described, however the whole 'display new page' logic in webslice is seriously borked and would require a general rewrite to make sure all bugs like this are fixed.
Created attachment 75569 [details]
Fix; also handles resizes
Last patch didn't handle resizing properly; this one does, although in an ugly way
Could you put the patch on https://git.reviewboard.kde.org/ so that developers can check it Figuring out all the magic required to make a proper review request is fscking irritating. Argh. Git commit 919370eba3978f641b8e8be1f3c2e299dc9c090d by Albert Astals Cid, on behalf of Mariusz Mazur. Committed on 05/04/2013 at 20:38. Pushed by aacid into branch 'KDE/4.10'. Fix webslice's handling of page resizes Acked by sebas REVIEW: 108458 FIXED-IN: 4.10.3 M +6 -1 applets/webslice/kgraphicswebslice.cpp http://commits.kde.org/kdeplasma-addons/919370eba3978f641b8e8be1f3c2e299dc9c090d I'm still having problems with this in 4.13.2. Every other refresh is too big for the window. |