Bug 310688

Summary:	skanlite- when clicking in setting and cancel it considers a new numbering
Product:	[Applications] Skanlite	Reporter:	Simple <simplew8>
Component:	general	Assignee:	Kåre Särs <kare.sars>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version:	0.7
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:	http://commits.kde.org/skanlite/eccaca1f4d8acd295a5d4ba553ed58e1b7d9e179	Version Fixed In:
Sentry Crash Report:

Description Simple 2012-11-26 03:41:54 UTC

If one clicks in settings and it hit Cancel button, kscanlite will act if the user clicked in OK button, since the numbering is reset and starts again from 0001

Reproducible: Always

Steps to Reproduce:
Already explained
Actual Results:  
Already explained

Expected Results:  
When clicking the Cancel button kscanlite should not reset numbering, and should continue from the last scanned number file

Comment 1 Kåre Särs 2012-11-26 06:06:49 UTC

There is no way to set the start number yet.

*** This bug has been marked as a duplicate of bug 310687 ***

Comment 2 Simple 2012-11-26 13:34:02 UTC

You have not read with the attention this bug report, its different from whats reported in bug #310687.

The problem here is if you click in button "settings" and if you hit the "cancel" butto, kscanlite will still consider that you have done some change and it will start numbering from 0, instead continue the numbering from the started task.

Comment 3 Kåre Särs 2012-11-26 13:59:55 UTC

The problem is that Skanlite starts from 1 every time and searches for the first available file name. If you delete a file it will gladly reuse that number. 

I noticed that in 0.8 (0.7 in the about), the place to save dialog is opened again if you have "open dialog for first only" and adds an extra number suffix to the name.  I did not check how it works on the totally automatic naming, it could be that it adds the extra number suffix there too.

In 0.9 (not in Ubuntu 12.10), the totally automatic naming is removed and the extra number suffix is not added, but the "first time" dialog is opened. The opening of the "first time" dialog could maybe be omitted after a cancel in the setup dialog...


I think I'll add a "Start from: ####" to the automatic naming.

Comment 4 Simple 2012-11-26 14:06:43 UTC

If you hit the button "Cancel" skanlite still considers as you have clicked in "Ok" button and starts a new numbering.
If you hit the "Cancel" button from the settings dialog, skanlite should continue with the task numbering that is active instead starting a new one.

Comment 5 Kåre Särs 2012-11-26 14:18:10 UTC

Yes image-####.png becomes image-0012####.png but that is fixed in trunk

So you start out with
image-0001.png
image-0002.png
image-0003.png
image-0004.png
image-0005.png
image-0006.png
Open settings and press "Cancel". Now you get:
image-00060001.png
image-00060002.png
image-00060003.png
image-00060004.png

The above is fixed in trunk (you still get the dialog tho)

Is this what you are seeing?

Comment 6 Kåre Särs 2012-11-27 20:45:44 UTC

Git commit eccaca1f4d8acd295a5d4ba553ed58e1b7d9e179 by Kåre Särs.
Committed on 27/11/2012 at 20:38.
Pushed by sars into branch 'master'.

Add option to set sequence-number
Do not open "first image" dialog after settings dialog has been canceled.
Related: bug 310687, bug 310689

M  +8    -8    src/SaveLocation.cpp
M  +27   -10   src/SaveLocation.ui
M  +32   -21   src/skanlite.cpp

http://commits.kde.org/skanlite/eccaca1f4d8acd295a5d4ba553ed58e1b7d9e179