Bug 310645

Summary: sftp error message: sentences mixed up
Product: [Unmaintained] kio Reporter: Michael G. Hansen <mike>
Component: sftpAssignee: Andreas Schneider <asn>
Status: RESOLVED FIXED    
Severity: normal CC: agateau, frank78ac, stgallag
Priority: NOR    
Version: 4.9.3   
Target Milestone: ---   
Platform: Ubuntu   
OS: Linux   
Latest Commit: http://commits.kde.org/kde-runtime/cd24bf87a05c5b3510c9df4260d4e1d2295f500e Version Fixed In: 4.9.5
Sentry Crash Report:
Attachments: Screenshot of error message

Description Michael G. Hansen 2012-11-25 12:58:53 UTC 
I entered sftp://name-of-host/ into the location bar. Then I got an error message right under the location bar: "Connection to host The host key for this server was not found, but another type of key exists.
An attacker might change the default server key to confuse your client into thinking the key does not exist.
Please contact your system administrator.
 is broken." (see screenshot).

Obviously the sentence "Connection to host is broken" and the real error message seem to be mixed.
Connection to the host works via fish, scp on the command line and ssh on the command line.



Reproducible: Always
Comment 1 Jekyll Wu 2012-11-25 15:39:18 UTC 
You forgot the screenshot :)
Comment 2 Frank Reininghaus 2012-11-25 17:03:33 UTC 
It looks like the text comes from "QString KIO::buildErrorString(int errorCode, const QString &errorText)", in kio/kio/global.cpp in kdelibs. But I'm not sure if that function is wrong or if it's being used incorrectly by KIO/sftp.
Comment 3 Michael G. Hansen 2012-11-25 19:48:46 UTC 
Created attachment 75474 [details]
Screenshot of error message

Here is the forgotten screenshot ;-)
Comment 4 Benni Hill 2012-12-08 17:20:52 UTC 
*** Bug 308799 has been marked as a duplicate of this bug. ***
Comment 5 Aurelien Gateau 2012-12-13 13:30:20 UTC 
Review request there: https://git.reviewboard.kde.org/r/107700/
Comment 6 Aurelien Gateau 2012-12-14 13:28:18 UTC 
Git commit 09a3d51e8c00f1a8d6662ea9a83ee593f0504eb7 by Aurélien Gâteau.
Committed on 13/12/2012 at 14:23.
Pushed by gateau into branch 'master'.

Fix mixed sentences in error messages
REVIEW: 107700

M  +6    -6    kioslave/sftp/kio_sftp.cpp

http://commits.kde.org/kde-runtime/09a3d51e8c00f1a8d6662ea9a83ee593f0504eb7
Comment 7 Aurelien Gateau 2012-12-14 13:44:45 UTC 
Git commit cd24bf87a05c5b3510c9df4260d4e1d2295f500e by Aurélien Gâteau.
Committed on 13/12/2012 at 14:23.
Pushed by gateau into branch 'KDE/4.9'.

Fix mixed sentences in error messages
REVIEW: 107700

M  +6    -6    kioslave/sftp/kio_sftp.cpp

http://commits.kde.org/kde-runtime/cd24bf87a05c5b3510c9df4260d4e1d2295f500e