| Summary: | Drag and drop not working properly in pager. | ||
|---|---|---|---|
| Product: | [Unmaintained] plasma4 | Reporter: | leo_rockway <leo> |
| Component: | widget-pager | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | major | CC: | 0inkane, laidig, mad.f3ka |
| Priority: | NOR | ||
| Version: | 4.9.90 Beta2 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=310758 | ||
| Latest Commit: | http://commits.kde.org/kde-workspace/9fef7c1caf16ed19dfb56c98ace417be80787801 | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: | Fixes dragging windows in pager | ||
|
Description
leo_rockway
2012-11-22 04:06:05 UTC
I can confirm this on Chakra linux, also using beta 1. There is also a dublicate bug report at https://bugs.kde.org/show_bug.cgi?id=310758 . After doing some testing, I'd say that line 136 in packages/contents/ui/main.qml drag.maximumY: root.height - 2*windowRect.height doesn't work, whereas it does work for root.height - windowRect.height (or 0.9 *windowRect.height) What was the idea behind the 2? I've tested in both vertical and horicontal panel mode, and it didn't work for me, whereas the change fixes/ works around it. For your information, this also happens with beta 2. Dragging doesn't work also if desktops are in one row (f.ex., 1x4). 4.9.90 (In reply to comment #2) > After doing some testing, I'd say that line 136 in packages/contents/ui/main.qml > drag.maximumY: root.height - 2*windowRect.height > doesn't work, whereas it does work for root.height - windowRect.height (or 0.9 *windowRect.height) Big thanks to you, Fabian! It works! PS: I think that windowRect.width and windowRect.height properties must be the same as in clipRect (for now, when you dragging a window, it rect is bigger than parent). Created attachment 75874 [details]
Fixes dragging windows in pager
This fixes a regression introduced with a990c98b2b3e6aceda8904f8ff36a03db533fbe6, (Reducing the drag area), which limited the drag area too much. Using 1 * windowRect.height (or simply windowRect.height) should also work, but (maybe only for me!) it seemed to work better (from a usability POV) when one is allowed to move the window a little bit more. Note that this doesn't adress the issue mentioned in the last post by Nikolay about windowRect's size.
Git commit 64a17885b22a13ae73e2a89d0e29216a5cf2b481 by Weng Xuetian. Committed on 22/12/2012 at 12:48. Pushed by xuetianweng into branch 'KDE/4.10'. Fix pager window dragging and icon the draggable region calculate for X and Y axis should use the same algorithm. width +/- rectwidth/2 REVIEW: 107828 M +3 -3 plasma/desktop/applets/pager/package/contents/ui/main.qml http://commits.kde.org/kde-workspace/64a17885b22a13ae73e2a89d0e29216a5cf2b481 Git commit 9fef7c1caf16ed19dfb56c98ace417be80787801 by Weng Xuetian. Committed on 23/12/2012 at 04:27. Pushed by xuetianweng into branch 'KDE/4.10'. port drag switch/drop window feature to qml REVIEW: 107843 M +31 -0 plasma/desktop/applets/pager/package/contents/ui/main.qml M +14 -0 plasma/desktop/applets/pager/pager.cpp M +1 -0 plasma/desktop/applets/pager/pager.h http://commits.kde.org/kde-workspace/9fef7c1caf16ed19dfb56c98ace417be80787801 |