Bug 310401

Summary: Move tool no longer moves current layer/layer with content
Product: [Applications] krita Reporter: Halla Rempt <halla>
Component: ToolsAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: admin
Priority: NOR    
Version: git master (please specify the git hash!)   
Target Milestone: ---   
Platform: unspecified   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description Halla Rempt 2012-11-20 09:50:21 UTC
After loading a multi-layer image (see attachment), it no longer matters which layer is current or which layer has content, only the layer that was active on loading gets moved with the move tool, until something gets painted on that layer. When creating a multi-layer image from scratch, moving layers works fine.
Comment 1 Halla Rempt 2012-11-20 09:51:18 UTC
the attachment is too big.
Comment 2 Dan Leinir Turthra Jensen 2012-11-20 09:55:31 UTC
Another way to trigger the move tool to work right again is to simply switch to another tool and switch back to the move tool.
Comment 3 Halla Rempt 2012-11-20 09:57:38 UTC
Dmitrh will fix it today :-)
Comment 4 Dmitry Kazakov 2012-11-20 12:11:34 UTC
Git commit 0e5c6071e30f679900732b35914a5b8c7214f875 by Dmitry Kazakov.
Committed on 20/11/2012 at 13:11.
Pushed by dkazakov into branch 'krita-new-move-tool-kazakov'.

Fixed the end of the Move Tool Stroke on various events

1) Switching Layer should enter the stroke
2) Changing tool configuration should end the stroke
3) Pressing Return/Enter should end the stroke

M  +4    -4    krita/image/kis_image.h
M  +10   -0    krita/plugins/tools/defaulttools/kis_tool_move.cc
M  +10   -1    krita/plugins/tools/defaulttools/kis_tool_move.h
M  +1    -0    krita/ui/input/kis_input_manager.cpp
M  +9    -0    krita/ui/input/kis_tool_invocation_action.cpp
M  +3    -0    krita/ui/kis_view2.cpp

http://commits.kde.org/calligra/0e5c6071e30f679900732b35914a5b8c7214f875
Comment 5 Dmitry Kazakov 2012-11-20 12:23:49 UTC
Git commit b28b11d0dd659323830267958a7f261aa3e64369 by Dmitry Kazakov.
Committed on 20/11/2012 at 13:15.
Pushed by dkazakov into branch 'master'.

Fixed the end of the Move Tool Stroke on various events

1) Switching Layer should enter the stroke
2) Changing tool configuration should end the stroke
3) Pressing Return/Enter should end the stroke

Conflicts:

	krita/ui/input/kis_input_manager.cpp

M  +4    -4    krita/image/kis_image.h
M  +10   -0    krita/plugins/tools/defaulttools/kis_tool_move.cc
M  +10   -1    krita/plugins/tools/defaulttools/kis_tool_move.h
M  +3    -0    krita/ui/input/kis_input_manager.cpp
M  +9    -0    krita/ui/input/kis_tool_invocation_action.cpp
M  +3    -0    krita/ui/kis_view2.cpp

http://commits.kde.org/calligra/b28b11d0dd659323830267958a7f261aa3e64369
Comment 6 Dmitry Kazakov 2012-12-02 07:15:22 UTC
Git commit a45b3ad3c904fb3dbea3fd57917a1cdf864dc8be by Dmitry Kazakov.
Committed on 20/11/2012 at 13:11.
Pushed by dkazakov into branch 'calligra/2.6'.

Fixed the end of the Move Tool Stroke on various events

1) Switching Layer should enter the stroke
2) Changing tool configuration should end the stroke
3) Pressing Return/Enter should end the stroke

M  +4    -4    krita/image/kis_image.h
M  +10   -0    krita/plugins/tools/defaulttools/kis_tool_move.cc
M  +10   -1    krita/plugins/tools/defaulttools/kis_tool_move.h
M  +1    -0    krita/ui/input/kis_input_manager.cpp
M  +9    -0    krita/ui/input/kis_tool_invocation_action.cpp
M  +3    -0    krita/ui/kis_view2.cpp

http://commits.kde.org/calligra/a45b3ad3c904fb3dbea3fd57917a1cdf864dc8be