| Summary: | JJ: tcsh context Cmd@ and CmdSet do not exist | ||
|---|---|---|---|
| Product: | [Applications] kate | Reporter: | Mark Greenwood <fatgerman> |
| Component: | general | Assignee: | KWrite Developers <kwrite-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | harshit93, i.zaufi, jaanvajakas, mwoehlke.floss, r.joosten, wbsoft |
| Priority: | NOR | Keywords: | junior-jobs |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/kate/cb94bbd610b7ed7f3421ee668fd348523b6d3229 | Version Fixed In: | 4.11.2 |
| Sentry Crash Report: | |||
|
Description
Mark Greenwood
2012-11-18 20:34:19 UTC
Matthew, Wilbert: Can you please take care of this? It seems the tcsh.xml file was never correct. *** Bug 310198 has been marked as a duplicate of this bug. *** And again. Matthew, Wilbert: Can you please take care of this? It seems the tcsh.xml file was never correct. (In reply to comment #3) > And again. > > Matthew, Wilbert: Can you please take care of this? > It seems the tcsh.xml file was never correct. I suppose tcsh highlighter became orphaned a long time ago... and looking into date of the bug report, nobody uses it... it is only a cause of annoyance when exporting colors (at least for me). I see 2 ways to deal w/ this case: 0) replace refs to undefined contexts (which are 'Cmd@' and 'CmdSet') w/ '#stay' -- making XML valid, but possible incorrect highlighter 1) just remove this file ... cuz it seems nobody care about it (cuz nobody use it)... also I suppose DTD should be fixed, so such type of errors will not appear in future. particularly 'name' of a 'context' element must be unique ID, not a CDATA. and attribute 'context' on other tags (common attributes) must be IDREF, not a CDATA. (In reply to comment #5) > also I suppose DTD should be fixed, so such type of errors will not appear > in future. > particularly 'name' of a 'context' element must be unique ID, not a CDATA. ... and must be #REQUIRED (I suppose contexts w/o name have no sense) > and attribute 'context' on other tags (common attributes) must be IDREF, not > a CDATA. oops. unfortunately this is impossible :( because of #stay and #pop[...] names which are not IDs :( (In reply to comment #4) > I suppose tcsh highlighter became orphaned a long time ago... and looking > into date of the bug report, nobody uses it... it is only a cause of > annoyance when exporting colors (at least for me). Well... yeah. I haven't looked at a .csh file in years. It's in VCS, so recoverable, so no objection by me to orphan and remove it. If anyone wants it again they can bring it back or ask someone to do so. (Not sure tweaking the DTD would help all that much; the real reason these errors exist is because the rules are only half-written :-).) Matthew, I'd prefer a fix over removing it. Care to spend some minutes? ;) I just updated my Linux box and sateted using the latest Kate to edit (among others) tcsh scripts. So you have a user. Well, one at least. Option 0: "replace refs to undefined contexts (which are 'Cmd@' and 'CmdSet') w/ '#stay' -- making XML valid, but possible incorrect highlighter" Did the trick for me. The highlighting remained sensible as well. Git commit 91dca1220b7f525be58d57413905457151fe8afb by Dominik Haumann. Committed on 13/09/2013 at 12:01. Pushed by dhaumann into branch 'master'. fix tcsh syntax highlighting FIXED-IN: 4.11.2 M +3 -3 part/syntax/data/tcsh.xml http://commits.kde.org/kate/91dca1220b7f525be58d57413905457151fe8afb Git commit cb94bbd610b7ed7f3421ee668fd348523b6d3229 by Dominik Haumann. Committed on 13/09/2013 at 12:01. Pushed by dhaumann into branch 'KDE/4.11'. fix tcsh syntax highlighting FIXED-IN: 4.11.2 M +3 -3 part/syntax/data/tcsh.xml http://commits.kde.org/kate/cb94bbd610b7ed7f3421ee668fd348523b6d3229 Thanks. Sorry, but I just have not had time to re-learn csh. Thanks for the fix. |