| Summary: | verbs duplicated in conjugation practise (times no. of personal pronouns) | ||
|---|---|---|---|
| Product: | [Applications] parley | Reporter: | kdebugs |
| Component: | general | Assignee: | parley bug tracker <parley-bugs-null> |
| Status: | RESOLVED WORKSFORME | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version First Reported In: | 0.9.4 | ||
| Target Milestone: | --- | ||
| Platform: | NetBSD pkgsrc | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
| Attachments: |
take testEntries.append() out of the per-pronoun loop
the dummy.kvtml for demonstrating the problem |
||
Created attachment 75268 [details]
take testEntries.append() out of the per-pronoun loop
alternatively, a break statement right after testEntries.append() might also do the job.
Created attachment 75269 [details]
the dummy.kvtml for demonstrating the problem
this is a minimalistic parley file to demonstrate the problem with practicing conjugations
Dear Bug Submitter, This bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? I am setting the status to NEEDSINFO pending your response, please change the Status back to REPORTED when you respond. Thank you for helping us make KDE software even better for everyone! Dear Bug Submitter, This is a reminder that this bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? This bug will be moved back to REPORTED Status for manual review later, which may take a while. If you are able to, please lend us a hand. Thank you for helping us make KDE software even better for everyone! Thank you for reporting this issue in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version? If you can reproduce the issue, please change the status to "REPORTED" when replying. Thank you! Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging If you have already provided the requested information, please mark the bug as REPORTED so that the KDE team knows that the bug is ready to be confirmed. Thank you for helping us make KDE software even better for everyone! This bug has been in NEEDSINFO status with no change for at least 30 days. The bug is now closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging Thank you for helping us make KDE software even better for everyone! |
in file src/practice/entryfilter.cpp, function EntryFilter::conjugationTestEntries(): when constructing the testEntries list, each verb is added again and again for every personal pronoun found active in the (non-blocked) vocabulary, instead of only once. Finally the testEntries list can grow as large as (no_of_verbs x no_of_personal_pronouns). Reproducible: Always Steps to Reproduce: 1. load dummy.kvtml. It contains 4 verbs (d1, d2, d3, d4) 2. under "Practice Mode", select "Conjugations", and mark tense "t1" 3. click "Start Practice" => 12 test entries Actual Results: parley wants to test 12 conjugations (when there are only 4 verbs) Expected Results: should test just 4 verbs relevant part of debug output: parley(10252) Practice::TestEntryManager::setDocument: Test from: "German" to: "dummy" parley(10252) Practice::EntryFilter::EntryFilter: Filter for 1 to 0 parley(10252) Practice::EntryFilter::EntryFilter: Tenses ("t1") parley(10252) Practice::EntryFilter::expireEntries: Expired words dropped their grade: 0 parley(10252) Practice::EntryFilter::cleanupInvalid: Invalid items removed. Remaining: 4 parley(10252) Practice::EntryFilter::entries: Document contains 4 valid entries. parley(10252) Practice::EntryFilter::conjugationTestEntries: Filtering conjugation entries for tenses... ("t1") parley(10252) Practice::TestEntryManager::setDocument: Found 24 entries after filtering. parley(10252) ConjugationOptions::updateSettings: Save language selection