Bug 310013

Summary:	holiday file for hong kong need to be updated
Product:	[Applications] kdepimlibs	Reporter:	Michael Tsang <miklcct>
Component:	kholidays	Assignee:	David E. Narvaez <david.narvaez>
Status:	RESOLVED UNMAINTAINED
Severity:	normal	CC:	david.narvaez, kdepim-bugs
Priority:	NOR
Version:	4.9
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	hong kong holiday file in english hong kong holiday file in chinese

Description Michael Tsang 2012-11-13 09:48:13 UTC

The legistation in Hong Kong for making up holidays was modified in this year, with effect from 2013. The new legistation cancels the exception that holidays were made up before the Sunday in case of Lunar New Year and Mid-autumn Festival, instead, they will be treated like everything else, with the make-up holiday placed after the Sunday (which is the 4th day from Lunar New Year and the 17th day in the eighth month respectively).

Reproducible: Always

Steps to Reproduce:
N/A
Actual Results:  
N/A

Expected Results:  
N/A

The legistation can be found through a link in the holidays file.

Comment 1 Christophe Marin 2013-01-18 23:56:03 UTC

It would help us if you attach updated holidays files to this bug report.

There are two holidays files afaics, one in english, the other one in chinese.

You can find them here: 
https://projects.kde.org/projects/kde/kdepimlibs/repository/revisions/master/entry/kholidays/holidays/plan2/holiday_hk_en-gb

https://projects.kde.org/projects/kde/kdepimlibs/repository/revisions/master/entry/kholidays/holidays/plan2/holiday_hk_zh-cn

Comment 2 Michael Tsang 2013-04-27 06:46:59 UTC

Created attachment 79486 [details]
hong kong holiday file in english

Comment 3 Michael Tsang 2013-04-27 06:48:16 UTC

Created attachment 79487 [details]
hong kong holiday file in chinese

Comment 4 Michael Tsang 2013-04-27 06:49:16 UTC

the one working on #317834 probably missed this

Comment 5 Christophe Marin 2013-04-27 09:34:35 UTC

Wrong files attached ? there's no difference except a new line at the end of each file

Comment 6 Denis Kurz 2016-09-24 20:55:13 UTC

This bug has only been reported for versions before 4.14, which have been unsupported for at least two years now. Can anyone tell if this bug still present?

If noone confirms this bug for a Framework-based version of kdepim (version 5.0 or later, as part of KDE Applications 15.08 or later), it gets closed in about three months.

Comment 7 Denis Kurz 2017-01-07 22:41:00 UTC

Just as announced in my last comment, I close this bug. If you encounter it again in a recent version (at least 5.0 aka 15.08), please open a new one unless it already exists. Thank you for all your input.