| Summary: | KTar asserts with certain files | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] kio | Reporter: | András Manţia <amantia> |
| Component: | tar | Assignee: | Mario Bensi <mbensi> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | annma, faure |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/kdelibs/fff2a02946cde51702ba77c51b03e2ff1d57810f | Version Fixed In: | 4.9.5 |
| Attachments: | File that triggers the crash also with ktartest | ||
Created attachment 74953 [details]
File that triggers the crash also with ktartest
I also hit this assert using KAppTemplate. Git commit fff2a02946cde51702ba77c51b03e2ff1d57810f by David Faure. Committed on 11/12/2012 at 13:42. Pushed by dfaure into branch 'KDE/4.9'. Skip pax extended headers, to avoid seeing "." twice. Use the same logic to skip pax global extended headers (added by recent commit). FIXED-IN: 4.9.5 M +12 -11 kdecore/io/ktar.cpp M +18 -0 kdecore/tests/karchivetest.cpp M +1 -0 kdecore/tests/karchivetest.h A +- -- kdecore/tests/tar_rootdir.tar.bz2 http://commits.kde.org/kdelibs/fff2a02946cde51702ba77c51b03e2ff1d57810f Which version of tar created the tar archive with Pax headers? My tar was 1.26 (same as yours). AFAIS that is used at build time to create the template archives. |
With the attached file KTar asserts with: ASSERT: "!d->rootDir" in file /encrypted/home/andris/development/sources/kde-trunk/kdelibs/kdecore/io/karchive.cpp, line 466 The problem is that rootDir is indeed set twice. Once in ktar.cpp line 471, the second time in line 481. The tar is created in kdevplatform/cmake/modules/KDevPlatformMacros.cmake with the following command: add_custom_command(OUTPUT ${_template} COMMAND tar ARGS -c -C ${CMAKE_CURRENT_SOURCE_DIR}/${_templateName} --exclude .kdev_ignore --exclude .svn -j -f ${_template} . DEPENDS ${_deps} ) (so you can see tha arguments) oassed. Reproducible: Always Actual Results: