Bug 309401

Summary:	Show "Desktop" fake item in window switcher preview if enabled
Product:	[Plasma] kwin	Reporter:	Kai Uwe Broulik <kde>
Component:	tabbox	Assignee:	KWin default assignee <kwin-bugs-null>
Status:	RESOLVED FIXED
Severity:	wishlist
Priority:	NOR
Version First Reported In:	git master
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:	https://invent.kde.org/plasma/kwin/commit/2797c64eea05df5f802231351a270164fa7c0fd6	Version Fixed/Implemented In:	5.24
Sentry Crash Report:

Description Kai Uwe Broulik 2012-11-02 00:29:59 UTC

In the window switcher kcm you have the ability to preview the selected layout. The Desktop item is not shown in that list when it is enabled, however. It should be there when enabled.

Reproducible: Always

Steps to Reproduce:
1. Open Window switcher KCM
2. Check "Include 'Show Desktop' icon"
3. Click preview
Actual Results:  
The preview opens with the given layout missing a desktop item

Expected Results:  
The preview opens with the given layout and has a "Show Destop" item

Comment 1 Bug Janitor Service 2021-11-26 23:59:38 UTC

A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/1718

Comment 2 Ismael Asensio 2021-11-30 21:39:03 UTC

Git commit 2797c64eea05df5f802231351a270164fa7c0fd6 by Ismael Asensio.
Committed on 30/11/2021 at 21:18.
Pushed by iasensio into branch 'master'.

kcm/tabbox: Make the preview show desktop if the option is selected

The thumbnail that represents the "desktop" in the switcher preview
is taken from the default wallpaper, and it will update automatically
as it changes in future versions of Plasma.

The current one is also added along the other thumbnails as a fallback.
FIXED-IN: 5.24

M  +6    -1    src/kcmkwin/kwintabbox/CMakeLists.txt
M  +35   -29   src/kcmkwin/kwintabbox/layoutpreview.cpp
M  +16   -7    src/kcmkwin/kwintabbox/layoutpreview.h
M  +3    -1    src/kcmkwin/kwintabbox/main.cpp
M  +6    -0    src/kcmkwin/kwintabbox/thumbnailitem.cpp
M  +2    -1    src/kcmkwin/kwintabbox/thumbnailitem.h
A  +-    --    src/kcmkwin/kwintabbox/thumbnails/desktop.png

https://invent.kde.org/plasma/kwin/commit/2797c64eea05df5f802231351a270164fa7c0fd6