| Summary: | Esc as the default shortcut of "Set Focus to The Panel" is problematic for the embedded terminal | ||
|---|---|---|---|
| Product: | [Applications] krusader | Reporter: | Till Schäfer <till2.schaefer> |
| Component: | shortcuts | Assignee: | Krusader Bugs Distribution List <krusader-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | adaptee, alex.bikadorov, clearmartin, jan_lepper, krusader-bugs-null, till2.schaefer, toni.asensi |
| Priority: | NOR | ||
| Version First Reported In: | 2.4.0-beta3 "Single Step" | ||
| Target Milestone: | --- | ||
| Platform: | Gentoo Packages | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/krusader/29e3c83c01500628112c2739d16168fee425434c | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: |
"Show" nomenclature in Krusader, instead of "show/hide"
"Show" nomenclature in Dolphin, instead of "show/hide" Instead of using a "Show-Hide" nomenclature, KDE normally uses a "Show" nomenclature and a disabled-or-enabled tick. |
||
|
Description
Till Schäfer
2012-10-31 10:13:19 UTC
My mistake of changing report status too eagerly... "Esc" is the shortcut of the "Set Focus to The Panel" action in shortcuts dialog, so it is already configurable. Also, the "Show Terminal Emulator" is a toggle action, so the same shortcut can be used to open/close the embedded terminal. nice to know! now it works for me. However i did not noticed any change other than the terminal situation when setting "Set Focus to The Panel" to no key. i am still able to do everything as before. what is it used for? if it is only used for the terminal i would propose to change the default behaviour to no key. As its name "Set Focus to The Panel" implies, it is used to transfer keyboard focus to the panel. But I agree "Esc" as its default shortcut is a bit problematic for applications running with the embedded terminal. (In reply to comment #3) > As its name "Set Focus to The Panel" implies, it is used to transfer > keyboard focus to the panel. > yes, but i didn find any use case. the foocus was always at the panel. (maybe i missed something) Note: in vim you can use ctrl-c to drop off insert mode Is there still something to do here. I understand that the escape key cannot be used in in the embedded terminal with the default shortcut. But first, it can be easily changed, and second, this is also true for any shortcut. There are tons of potential shortcut conflicts. The proposals here are * to change the misleading description to shortcut entry from "Show Terminal Emulator" to "Show/Hide Terminal Emulator", because: * it is obviously a imprecise shortcut description * to set "Set Focus to The Panel" to "no key" by default, because: * eliminating shortcut conflicts is good :-) * The ESC key is not needed, as the "Show Terminal Emulator" shortcut also hides the terminal emulator > * to change the misleading description to shortcut entry from "Show Terminal > Emulator" to "Show/Hide Terminal Emulator" We have to notice that there are a lot of uses of the "show" word (not "show/hide"), and every one should be changed, I'll attach an screenshot. Other programs, like Dolphin, also use the word "show" instead of "show/hide", it seems to be the norm, I'll attach another screenshot. > * to set "Set Focus to The Panel" to "no key" by default, because: > * eliminating shortcut conflicts is good :-) > [...] Maybe it's better not to use Esc to "Set Focus to The Panel" because it's used by a lot of programs that may be running in the embedded terminal. Nowadays Ctrl+Up can be used to "set focus to the panel", and also.. Ctrl+Down to return from the panel to the embedded terminal, those shortcuts are intuitive, related one to another, and easy to remember. Created attachment 103150 [details]
"Show" nomenclature in Krusader, instead of "show/hide"
Created attachment 103151 [details]
"Show" nomenclature in Dolphin, instead of "show/hide"
I agree with Toni, "show XYZ" is used in all KDE applications instead of "show/hide". I wouldn't change it. "Ctrl+Up/down" is already used for toggling the focus between navigation bar and panel. And also a hardcoded shortcut in terminal emulator and command line for toggling focus. Additionally there is the "Ctrl+Shift+up/down" QAction shortcut to move the focus up/down between widgets. So yes, I think we can remove the default "Escape" shortcut(?). I also agree with keeping the "Show XYZ" and removing the default "Escape" shortcut. Git commit 29e3c83c01500628112c2739d16168fee425434c by Alexander Bikadorov. Committed on 07/01/2017 at 21:30. Pushed by abikadorov into branch 'master'. FIXED: [ 309300 ] Esc as the default shortcut of "Set Focus to The Panel" is problematic for the embedded terminal Default "Escape" shortcut removed. M +1 -1 krusader/Panel/viewactions.cpp https://commits.kde.org/krusader/29e3c83c01500628112c2739d16168fee425434c Created attachment 103281 [details]
Instead of using a "Show-Hide" nomenclature, KDE normally uses a "Show" nomenclature and a disabled-or-enabled tick.
Instead of using a "Show-Hide" nomenclature, KDE normally uses a "Show" nomenclature and a disabled-or-enabled tick.
|