| Summary: | Task name field is empty in edit history dialog | ||
|---|---|---|---|
| Product: | [Applications] ktimetracker | Reporter: | edward.lara.lara |
| Component: | general | Assignee: | Zoltan Gyarmati <mr.zoltan.gyarmati> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | normal | CC: | Nikolaus |
| Priority: | NOR | ||
| Version First Reported In: | Git (master) | ||
| Target Milestone: | --- | ||
| Platform: | Fedora RPMs | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
| Attachments: | History edit dialog patch | ||
I can confirm that this is still a problem in 4.11.5, and that the above patch fixes it. I have also attached it as a patchfile so that it's easier to apply. Created attachment 86394 [details]
History edit dialog patch
*** This bug has been marked as a duplicate of bug 305239 *** |
After upgrading from a previous version (kdepim-4.8.5-4.fc16.x86_64) with an existing task list the edit history dialog shows the tasks but the task name is empty. The new version is not listed (kdepim-4.9.2) but the code matches git master Reproducible: Always Steps to Reproduce: 1. Have a ktimetracker.ics from a previous version 2. Add some times to the history 3. Open the Edit History dialog from the menu (File/Edit History...) Actual Results: The task list will show up but the task name will be empty Expected Results: The task name field should have the corresponding task name from the main window I do not see a way to attach a file to the bug, but here is the patch that fixed this for me: --- kdepim-4.9.2/ktimetracker/historydialog.cpp.missing-names 2012-10-23 16:38:36.938774896 -0400 +++ kdepim-4.9.2/ktimetracker/historydialog.cpp 2012-10-23 16:38:43.222781901 -0400 @@ -113,7 +113,7 @@ if ( !(*i)->relatedTo().isEmpty() ) // maybe the file is corrupt and (*i)->relatedTo is NULL { KCalCore::Incidence::Ptr parent = calendar ? calendar->incidence( (*i)->relatedTo() ) : KCalCore::Incidence::Ptr(); - item = new QTableWidgetItem( parent ? parent->summary() : QString() ); + item = new QTableWidgetItem( parent ? parent->summary() : (*i)->summary() ); item->setFlags( Qt::ItemIsEnabled ); item->setWhatsThis( i18n( "You can change this task's comment, start time and end time." ) ); m_ui->historytablewidget->setItem( row, 0, item );