| Summary: | Misleading icon on notification when denying authorization | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] telepathy | Reporter: | Daniele E. Domenichelli <ddomenichelli> |
| Component: | kded-module | Assignee: | Telepathy Bugs <kde-telepathy-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | kde, mklapetek, rohan |
| Priority: | NOR | Keywords: | junior-jobs |
| Version: | git-latest | ||
| Target Milestone: | Future | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/telepathy-kded-module/b8980fd4c336d6deda852d2dcbb96d6c31a85b4a | Version Fixed In: | 0.6.0 |
|
Description
Daniele E. Domenichelli
2012-10-24 07:42:22 UTC
I remember when designing this, we put the green tick in there as "operation completed successfully" as big red things in cross shape are scary and usually mean "error". In my opinion we should show dialog-information in order to inform the user about the result of this action What about "list-remove-user" (and perhaps change also the icon for success to "list-add-user") The green tick is the same used for the "Approve" action icon, so it's really misleading. That depends on what the icon should actually show. I never saw it as misleading because I always thought about it as "operation completed". However I'm fine with changing it to either "list-remove-user" or "dialog-information" (and if it will be changed, change the "approved" one as well). change to dialog-information Git commit b8980fd4c336d6deda852d2dcbb96d6c31a85b4a by Andrea Scarpino. Committed on 07/02/2013 at 13:56. Pushed by scarpino into branch 'master'. Fix misleading icon on notification when denying authorization M +1 -1 contact-request-handler.cpp http://commits.kde.org/telepathy-kded-module/b8980fd4c336d6deda852d2dcbb96d6c31a85b4a |