Bug 308895

Summary: Handle Enter key as well as Return to send message
Product: [Unmaintained] telepathy Reporter: David Edmundson <kde>
Component: text-uiAssignee: Telepathy Bugs <kde-telepathy-bugs>
Status: RESOLVED FIXED    
Severity: major    
Priority: NOR    
Version: 0.5.1   
Target Milestone: Future   
Platform: unspecified   
OS: Linux   
Latest Commit: Version Fixed In: 0.5.2
Sentry Crash Report:

Description David Edmundson 2012-10-23 18:17:35 UTC
Some people with quirky keyboards have a return key that appears as:

[11:14] <ciummo> KeyPress event, serial 34, synthetic NO, window 0x5400001,     root 0xac, subw 0x0, time 8823377, (7,335), root:(621,385),     state 0x0, keycode 104 (keysym 0xff8d, KP_Enter), same_screen YES, "   XLookupString gives 1 bytes: (0d) " "   XmbLookupString gives 1 bytes: (0d) "     XFilterEvent returns: False

this means it misses

if (e->key()==Qt::Key_Return && !e->modifiers()) {
 Q_EMIT returnKeyPressed();
 return;
}
Comment 1 Rohan Garg 2012-10-23 18:35:43 UTC
Git commit 558554b15ac75817881536546d8e9bc827e9bc61 by Rohan Garg, on behalf of David Edmundson.
Committed on 23/10/2012 at 20:27.
Pushed by garg into branch 'master'.

Allow sending messages with the enter key as well as return.

M  +1    -1    lib/chat-text-edit.cpp

http://commits.kde.org/telepathy-text-ui/558554b15ac75817881536546d8e9bc827e9bc61
Comment 2 Rohan Garg 2012-10-23 18:37:41 UTC
Git commit 880d89e43550d2631c377bc23f0bacb6cfa98f5a by Rohan Garg, on behalf of David Edmundson.
Committed on 23/10/2012 at 20:27.
Pushed by garg into branch 'kde-telepathy-0.5'.

Allow sending messages with the enter key as well as return.

M  +1    -1    lib/chat-text-edit.cpp

http://commits.kde.org/telepathy-text-ui/880d89e43550d2631c377bc23f0bacb6cfa98f5a