Bug 308281

Summary:	default spell language set wrongly?
Product:	[Unmaintained] telepathy	Reporter:	Alin M Elena <alinm.elena>
Component:	text-ui	Assignee:	Telepathy Bugs <kde-telepathy-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	kde
Priority:	NOR	Keywords:	junior-jobs
Version:	git-latest
Target Milestone:	0.6.0
Platform:	unspecified
OS:	Linux
Latest Commit:	http://commits.kde.org/telepathy-text-ui/3ec947f7c7e3c223497984b47742e3e4a0cc6009	Version Fixed In:
Sentry Crash Report:

Description Alin M Elena 2012-10-12 08:57:58 UTC

context... I have 3 languages installed on my computer for spelling purposes... English, Romanian, Italian... English is the default... 

When I start chat with a contact to whom I never assigned a language it correctly defaults to English, Let us call that contact A.

Now I set the spelling language of a contact to let us say Romanian, contact B... (if I close the text-ui and restart the coversation, the language is correctly set)

I start a conversation with B and then with A (my setting is to start a new tab in the same text-ui). Now the language of contact A is Romanian...

Practically with the ways are now a contact with no language set gets assigned a random language from the ones available.

the default language or preferred (I think kde calls it like that), it is the first entry in the list of languages it returns iirc.

Alin

Reproducible: Always

Comment 1 David Edmundson 2013-01-17 13:42:57 UTC

Spell check language is correct, that combo box does not default to the correct thing when shown

Comment 2 Alin M Elena 2013-01-17 14:29:44 UTC

I know I was trying to be polemic... If I would not be so lazy... I could in principle even fix it.

Alin

Comment 3 David Edmundson 2013-03-20 11:09:26 UTC

This is really annoying me. This is now blocking the 0.6.0 release.

Comment 4 David Edmundson 2013-03-24 10:53:05 UTC

Aha, found a problem, KLocale()->language() is not the spell check language, just the general one. This is wrong.

I assume there's a method in Sonnet we should be using.

Comment 5 David Edmundson 2013-03-24 14:55:55 UTC

Should be Sonnet::Settings::defaultLanguage()

Comment 6 Alin M Elena 2013-03-26 18:20:29 UTC

Git commit 3ec947f7c7e3c223497984b47742e3e4a0cc6009 by Alin M Elena.
Committed on 26/03/2013 at 19:18.
Pushed by elena into branch 'master'.

Sets correctly the default spell language for a new tab
REVIEW: 109740

M  +4    -2    lib/chat-widget.cpp

http://commits.kde.org/telepathy-text-ui/3ec947f7c7e3c223497984b47742e3e4a0cc6009