| Summary: | Zoom effect broken in master | ||
|---|---|---|---|
| Product: | [Plasma] kwin | Reporter: | Christoph Feck <cfeck> |
| Component: | effects-various | Assignee: | KWin default assignee <kwin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version: | git master | ||
| Target Milestone: | 4.10 | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/kde-workspace/8171c12ed8ba4c26c715afb35063c8084c10c7e4 | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: | qdbus org.kde.kwin /KWin supportInformation | ||
qdbus org.kde.kwin /KWin supportInformation says: zoomFactor: 0.1 but in the settings dialog of the Zoom plugin, I see 2.0. Set it to 120 It's commit 150cba5552312642466f2ecccfc383140faa48fe (KConfigXT) The scale dimension was adjusted (f/100), but the UI still has a doublespinbox and i'm not sure whether there's been a kconf update script that should have been running. thanks for the note, yeah kconf update script is missing. I will add that once the review is merged which introduces a kconf update script (plastik). Also cube effect needs an adjustment and translucency (that's why it's not yet merged) diff --git a/kwin/effects/zoom/zoom.cpp b/kwin/effects/zoom/zoom.cpp
index 587de03..2c42ae8 100644
--- a/kwin/effects/zoom/zoom.cpp
+++ b/kwin/effects/zoom/zoom.cpp
@@ -206,7 +206,7 @@ void ZoomEffect::reconfigure(ReconfigureFlags)
{
ZoomConfig::self()->readConfig();
// On zoom-in and zoom-out change the zoom by the defined zoom-factor.
- zoomFactor = qMax(0.1, ZoomConfig::zoomFactor()/100.0);
+ zoomFactor = qMax(0.1, ZoomConfig::zoomFactor());
// Visibility of the mouse-pointer.
mousePointer = MousePointerType(ZoomConfig::mousePointer());
// Track moving of the mouse.
--
The KConfigXT uses 1.20 as default, so the divisor is wrong.
@Martin, got a push ok?
(In reply to comment #4) > @Martin, got a push ok? ship it Git commit 8171c12ed8ba4c26c715afb35063c8084c10c7e4 by Thomas Lübking. Committed on 30/09/2012 at 13:50. Pushed by luebking into branch 'master'. fix zoom factor scale, remains double M +1 -1 kwin/effects/zoom/zoom.cpp http://commits.kde.org/kde-workspace/8171c12ed8ba4c26c715afb35063c8084c10c7e4 |
Created attachment 74241 [details] qdbus org.kde.kwin /KWin supportInformation Zoom effect ("Magnify the entire desktop") does no longer work. The last compile is about two weeks ago, so a lot of commits could have introduced it. I have set scale factor to 2.0, but pressing the Zoom In hotkey, the screen turns black, and only a very small thumbnail of the screen appears. Interestingly, using Zoom Out instead will zoom in, but not by a factor of 2.0, but much more (10.0?).