| Summary: | The hidden option "EnlargeSmallPreviews" does not work any more | ||
|---|---|---|---|
| Product: | [Applications] dolphin | Reporter: | Frank Reininghaus <frank78ac> |
| Component: | view-engine: general | Assignee: | Frank Reininghaus <frank78ac> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | nuno |
| Priority: | NOR | ||
| Version: | 2.1 | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: |
First draft of a patch
Updated patch |
||
|
Description
Frank Reininghaus
2012-09-28 10:42:41 UTC
Created attachment 74235 [details]
First draft of a patch
The commit that broke it appears to be 2069c200211c93e401c3d19850f41eade09d64be
This is what I've achieved so far: Icons are not scaled up any more when the settings is disabled, the icons are centered at the bottom, and no frame is drawn. However, strange arrows are painted next to some icons for me. I have no idea why :-(
Git commit 0b72170cd525e35db11dd48b230da9e567bb99b4 by Frank Reininghaus. Committed on 03/10/2012 at 10:14. Pushed by freininghaus into branch 'KDE/4.9'. Fix the hidden "EnlargeSmallPreviews" option This option, introduced in 99e4eb0f3a58c53277b099114a5fd8945937fb9a, did not work any more since 2069c200211c93e401c3d19850f41eade09d64be. M +4 -1 dolphin/src/views/dolphinview.cpp http://commits.kde.org/kde-baseapps/0b72170cd525e35db11dd48b230da9e567bb99b4 Created attachment 74313 [details]
Updated patch
This is the patch which makes the icons centered at the bottom without frame, rebased on my recent commit. Unfortunately, the issue with the strange arrows remains.
It seems that the strange arrows appear in every case, even with the current state of the 4.9 branch... Nuno, the option should be working now in the 4.9 branch, therefore, I'm closing this report. Some things that I can do additionally if you want: a) Remove the frame if the 'EnlargeSmallPreviews' option is disabled b) Do not center icons, but show them centered at the bottom if the option is disabled. If you want one or both of these options, just add a comment here and I'll take care of it. |