| Summary: | Dolphin doesn't respect the Samba "hide files" option | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] kio-extras | Reporter: | Dane <mlist+kdebugs> |
| Component: | Samba | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | adawit, frank78ac, nate, yannik |
| Priority: | NOR | ||
| Version: | 18.04.2 | ||
| Target Milestone: | --- | ||
| Platform: | Debian testing | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/kio-extras/e2eadb7555a6320b2e2b5a20248940d2f78d9823 | Version Fixed In: | 19.12.3 |
| Sentry Crash Report: | |||
Additionally, I've seen this behaviour on the Ubuntu and Arch packages, so I don't believe this is limited to the Debian releases. Thanks for the bug report! I have never worked on Samba issues (or even used Samba seriously myself). Do you happen to know how Samba stores the information about the files that should be hidden? Actually, this looks more like it should be fixed in the smb kioslave, not in Dolphin. *** This bug has been marked as a duplicate of bug 197903 *** https://bugs.kde.org/show_bug.cgi?id=197903 is not a duplicate of this ticket! even though related as it involves samba and dolphin, this bug is completely different! Can anyone reopen this or will I need to create a new bug? Git commit e2eadb7555a6320b2e2b5a20248940d2f78d9823 by Harald Sitter. Committed on 13/02/2020 at 11:16. Pushed by sitter into branch 'master'. smb: support more advanced hidden file flag Summary: smb attaches different meaning to the +x flags of files to represent DOS style flags. read them and hide hidden files. we currently have no KIO backing for the others but for documentation purpose I've mentioned them in detail so we can extend this in the future without having to descend into samba docs. FIXED-IN: 19.12.3 Test Plan: - set jpgs hidden as described in bug report - they are now hidden in dolphin Reviewers: ngraham Reviewed By: ngraham Subscribers: kde-frameworks-devel, kfm-devel Tags: #dolphin, #frameworks Differential Revision: https://phabricator.kde.org/D27295 M +15 -0 smb/kio_smb_browse.cpp https://commits.kde.org/kio-extras/e2eadb7555a6320b2e2b5a20248940d2f78d9823 |
Dolphin doesn't respect the 'hide files' option in the Samba configuration file. On my home server, I have 'hide files' set to the following on a share in order to hide HTPC metadata when I'm viewing the share on my PCs. The hide files option is respected under Gnome and Windows, but as far as I'm aware, has never been respected under KDE. hide files = /*.xml/*.metathumb/*.jpg/*.jpeg/ This makes it very difficult to limit my view to only files I want to see. Reproducible: Always Steps to Reproduce: 1. Set 'hide files' option in smb.conf for a share. 2. Open share in Dolphin. 3. Actual Results: I can see the files I've asked Samba to hide. Expected Results: Like Windows and Gnome, I would expect is that the files specified under the 'hide files' option be hidden from view unless the "Show Hidden Files" option is enabled in Dolphin. (Although in my case if they never showed up at all I'd be happy with that too!)