Bug 307351

Summary: konsoleprofile quoting broke
Product: [Applications] konsole Reporter: Matthew Woehlke <mwoehlke.floss>
Component: generalAssignee: Konsole Developer <konsole-devel>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: 2.8.5   
Target Milestone: ---   
Platform: Fedora RPMs   
OS: Linux   
Latest Commit: http://commits.kde.org/konsole/f127a77ca9d248a55d22a64bc90590e399bfdeda Version Fixed In: 4.9.2
Sentry Crash Report:
Attachments: git patch

Description Matthew Woehlke 2012-09-24 21:51:36 UTC 
konsoleprofile "value=two words" no longer works. This is a regression from the previous version I had installed (which AFAICT was from KDE 4.8.5).

More specifically, it was broken in 4e1b96e4.

The fix is to add ""s around $1.

Reproducible: Always
Comment 1 Matthew Woehlke 2012-09-24 21:54:52 UTC 
Created attachment 74148 [details]
git patch

Even better, here's the 'git am'-able patch to fix it.
Comment 2 Jekyll Wu 2012-09-24 22:54:56 UTC 
Thanks for reporting . I will push the fix for you :)
Comment 3 Jekyll Wu 2012-09-24 22:55:43 UTC 
Git commit 7d05ceedf80a140b465b1b35851f7179ddd89e2e by Jekyll Wu, on behalf of Matthew Woehlke.
Committed on 24/09/2012 at 23:52.
Pushed by jekyllwu into branch 'master'.

fix broken quoting in konsoleprofile

Add missing quotes around '$1' in konsoleprofile so that we do not
perform word splitting twice (which is very unlikely to be what the user
wants, and is difficult or impossible to prevent). This fixes a
regression introduced in 4e1b96e4.
FIXED-IN: 4.9.2

M  +1    -2    src/konsoleprofile

http://commits.kde.org/konsole/7d05ceedf80a140b465b1b35851f7179ddd89e2e
Comment 4 Jekyll Wu 2012-09-24 22:57:13 UTC 
Git commit f127a77ca9d248a55d22a64bc90590e399bfdeda by Jekyll Wu, on behalf of Matthew Woehlke.
Committed on 24/09/2012 at 23:52.
Pushed by jekyllwu into branch 'KDE/4.9'.

fix broken quoting in konsoleprofile

Add missing quotes around '$1' in konsoleprofile so that we do not
perform word splitting twice (which is very unlikely to be what the user
wants, and is difficult or impossible to prevent). This fixes a
regression introduced in 4e1b96e4.
FIXED-IN: 4.9.2
(cherry picked from commit 7d05ceedf80a140b465b1b35851f7179ddd89e2e)

M  +1    -2    src/konsoleprofile

http://commits.kde.org/konsole/f127a77ca9d248a55d22a64bc90590e399bfdeda