Bug 307291

Summary: Improve usability and fix bugs [patch]
Product: [Applications] digikam Reporter: Peter Potrowl <peter017>
Component: Plugin-WebService-MediaWikiAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: caulier.gilles
Priority: NOR    
Version First Reported In: 3.0.0   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: http://commits.kde.org/kipi-plugins/696d24e840ae09c2f892afaac7cd106a9bdaa992 Version Fixed/Implemented In: 3.0.0
Sentry Crash Report:
Attachments: Improvements described in my first post.

Description Peter Potrowl 2012-09-23 22:19:10 UTC 
This patch fix the following bugs:

1) This plugin is made for uploading files to a MediaWiki-based service, not to Wikimedia, which is a Foundation. The patch fixes this vocabulary issue in some places, but not everywhere.

2) The text content in KTextEdit elements is used to produce a wikitext for the destination wiki. We do not want to treat RichText, so, we disable RichText in KTextEdit elements.

3) The editingFinished signal is called even when the text inside the KLineEdit element was not modified. This is not the expected behavior for this plugin and can cause losses of information to the user. This patch replaces the editingFinished signal with textEdited signal in some places to avoid this problem.

4) The plugin used to upload not the files listed in its window but the files selected in digiKam, which is absolutely not the expected behavior: adding or removing files in the list had no impact on which files would be uploaded. This patch fixes this problem.

5) The user might want to copy information from the window after the upload, so, we don't hide the window automatically after upload anymore.

6) As requested by a user comment, this patch cleans the list of destination wikis and sort them by order of importance.

Can you please apply this patch to the trunk, please?

Best regards

Reproducible: Always
Comment 1 Peter Potrowl 2012-09-23 22:19:34 UTC 
Created attachment 74126 [details]
Improvements described in my first post.
Comment 2 caulier.gilles 2012-09-24 05:30:00 UTC 
Git commit 696d24e840ae09c2f892afaac7cd106a9bdaa992 by Gilles Caulier.
Committed on 24/09/2012 at 07:28.
Pushed by cgilles into branch 'master'.

apply patch #74126 from Peter Potrowl

M  +58   -58   mediawiki/kipiplugin_wikimedia.desktop.cmake
M  +65   -31   mediawiki/wmwidget.cpp
M  +1    -0    mediawiki/wmwidget.h
M  +1    -2    mediawiki/wmwindow.cpp

http://commits.kde.org/kipi-plugins/696d24e840ae09c2f892afaac7cd106a9bdaa992