Bug 307107

Hi Torsten. Can you please build Kate by following http://kate-editor.org/get-it/ and test, whether this is already fixed? This would be a huge help. Alternatively, try KDE 4.9.x.

Created attachment 74209 [details]
patch to fix comparison of signed/unsigned

The 1st two affect local vars => IMHO save but the 3rd needs review by s/o who is "in" the source code!!!

Hi Torsten: Question remains: Can you confirm this is fixed now, or is the initial issue still there?

PS: The patch is somehow unrelated...

Hi Dominik,

no, it isn't fixed neither in the version I compiled from git nor in the update I got from KDE SC 4.9 via kubuntu backports-ppa later (the two versions look the same).
Settings handling is improved, but still somewhat buggy :/
I found out that there are problems with string handling for saved settings.  I had unusual names for <item datas> in my syntax file - with backslash and spaces - that could not not be written and read back correctly in the cache and settings files.  Maybe that's related.  The settings are spread over _various_ cache and ini files.  From my experience I can say that after some time of programming such a module I have a gordic knot between my ears and make mistakes...

Created attachment 75266 [details]
test_syntax.pl

I rewrote most parts of that code yesterday and if I try your steps from the first comment, it is saved well, too.

And yeah, the stuff is split mostly in two files: kateschemarc for the base colors and font, katesyntaxhighlightingrc for the highlighting colors (default + specialized).

Could you retry? (The unsigned/signed stuff is fixed, too, beside the on in kateviewinternal, that needs one look more ;)

I downloaded and installed from git like described on the Kate web page.
Unfortunately, the bug is still there :(
Steps to reproduce:
0. Have the ISO-Prolog syntax file (prolog-iso.xml) installed in your 
~/.kde/share/apps/katepart/syntax folder.
1. load the test syntax file
2. Open the fonts & colors settings
3. Disable the background color and selected background color of "ISO Bogus"
   (Right mouse click on the color field)
4. Click "Apply"

Status Quo: The background colors come back.

I deleted the "Prolog (ISO)" settings in 
~/.kde/share/config/katesysntaxhighlightingrc before testing.

To say it with Melody: "Who Will Comfort Me?"...
http://www.youtube.com/watch?v=SntJNLeHNS0

Have a nice day and smile,  =|o)

Am Samstag, 3. November 2012, 14:42:16 schrieben Sie:
> https://bugs.kde.org/show_bug.cgi?id=307107
> 
> Christoph Cullmann <cullmann@kde.org> changed:
> 
>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
> Status|UNCONFIRMED                 |NEEDSINFO
>                  CC|                            |cullmann@kde.org
>          Resolution|---                         |WAITINGFORINFO
> 
> --- Comment #5 from Christoph Cullmann <cullmann@kde.org> ---
> I rewrote most parts of that code yesterday and if I try your steps from the
> first comment, it is saved well, too.
> 
> And yeah, the stuff is split mostly in two files: kateschemarc for the base
> colors and font, katesyntaxhighlightingrc for the highlighting colors
> (default + specialized).
> 
> Could you retry? (The unsigned/signed stuff is fixed, too, beside the on in
> kateviewinternal, that needs one look more ;)

Created attachment 75267 [details]
prolog-iso.xml.zip

Created attachment 95183 [details]
Proposed fix

So I think I've found the error and attaching the patch to fix it.
The most proper way to fix this  should be renaming enums to enum-classes (C++11 feature) but I suppose it will break some other projects that use ktexteditor api, so I just added type specifier.

(In reply to Oleksandr Senkovych from comment #8)
> Created attachment 95183 [details]
> Proposed fix
> 
> So I think I've found the error and attaching the patch to fix it.
> The most proper way to fix this  should be renaming enums to enum-classes
> (C++11 feature) but I suppose it will break some other projects that use
> ktexteditor api, so I just added type specifier.

Oops, sorry, this patch doesn't fix all problem places. Added a new one to phabricator: https://phabricator.kde.org/D457

Fixed in ktexteditor.git:

commit 4e1fb2a5f1c74510c1a1e1ab91260735c1df21bf
Author: Oleksandr Senkovych <bjsenya@gmail.com>
Date:   Thu Oct 29 11:14:07 2015 +0100

    Fix bug #307107
    
    (Kate does not save and reflect disabling background color settings for highlighting)
    
    Summary: Naming issue: enum items from KateStyleTreeWidgetItem::columns had same names as CustomProperties and were used for getting text attribute properties.
    
    Test Plan: Successfully saved background color settings after applying a patch
    
    Differential Revision: https://phabricator.kde.org/D457

*** Bug 355615 has been marked as a duplicate of this bug. ***

*** Bug 340032 has been marked as a duplicate of this bug. ***