Bug 306903

Summary: Inconsistent use of bold text
Product: [Plasma] plasma4 Reporter: David Edmundson <kde>
Component: widget-batteryAssignee: Plasma Bugs List <plasma-bugs>
Severity: normal CC: de.meyer.maarten, micheluzzo
Priority: NOR    
Version: 4.9-git   
Target Milestone: ---   
Platform: unspecified   
OS: Linux   
Latest Commit: Version Fixed In:
Bug Depends on:    
Bug Blocks: 303462    
Attachments: adapts tooltip's bold usage to match the widget

Description David Edmundson 2012-09-16 23:07:03 UTC
Tooltip of battery plasmoid reads

<b>Battery:</b> 4%

whereas the dialog that pops up reads

Battery: <b>4%</b>

Either could be argued as correct, but a mix is definitely not.

The latter fits more in line with other usages in plasma and other applications. Ideally this should make it into the Plasma HIG.
Comment 1 Michele Gastaldo 2012-10-25 16:02:53 UTC
Created attachment 74796 [details]
adapts tooltip's bold usage to match the widget

This should fix the problem, making the tooltip's text look like in the widget. I also believe this is the best way, as in other widgets...but also as suggested by at least one developer (http://www.sharpley.org.uk/node/22)

Be aware that this is my first patch, so there is no certainty that it's free from mistakes :)
Comment 2 Michele Gastaldo 2012-10-25 16:05:15 UTC
err..I notice only now that there is a strange coincidence between the bug reporter and the author of the blog I referred to.. :D
Comment 3 Maarten De Meyer 2012-10-30 13:23:42 UTC
You should post your patch on reviewboard.kde.org
Thank you!
Comment 4 David Edmundson 2012-11-05 11:59:10 UTC
Git commit 57b1d235d52c5402ae46a589276a2e8bd704d363 by David Edmundson, on behalf of Michele Gastaldo.
Committed on 05/11/2012 at 12:55.
Pushed by davidedmundson into branch 'master'.

Fix bold text in battery-monitor tooltip

Makes usage of bold text in the tooltip consistent with the widget.

M  +8    -8    plasma/generic/applets/batterymonitor/contents/code/logic.js