Bug 306540

Summary:	light-green color lost in BlackOnLightYellow.colorscheme
Product:	[Applications] konsole	Reporter:	Leendert Meyer <leen.meyer>
Component:	general	Assignee:	Konsole Bugs <konsole-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	2.9.1
Target Milestone:	---
Platform:	openSUSE
OS:	Linux
Latest Commit:	http://commits.kde.org/konsole/f6456664f0f2aed9c677c1113aa2fa84b931070d	Version Fixed/Implemented In:	4.9.2
Sentry Crash Report:

Description Leendert Meyer 2012-09-10 11:43:35 UTC

Instead of a light-green foreground color, a black color is shown when using BlackOnLightYellow.colorscheme

Apparently between revisions 46ff0109 and 8355ccaa a bit more was removed than probably intended:

https://projects.kde.org/projects/kde/kde-baseapps/konsole/repository/diff/data/color-schemes/BlackOnLightYellow.colorscheme?rev=8355ccaa824ee2f358dc3f636f2f6bac2f42183b&rev_to=46ff01094dd6463ead26fefba0d8f535a2e0f107

Reproducible: Always

Steps to Reproduce:
1.Open a konsole window
2.Select the black on light-yellow colorscheme
3.Issue: echo -e "Normal color - \033[32m\033[1mLight-green color\033[m - Normal again."
Actual Results:  
The text "Light-green color" is shown in black-colored letters.

Expected Results:  
The text "Light-green color" should be shown in light-green-colored letters.

Here is a unified diff for a fix:

--- BlackOnLightYellow.colorscheme.old  2012-09-10 13:15:20.547025206 +0200
+++ BlackOnLightYellow.colorscheme      2012-09-10 13:13:34.667220586 +0200
@@ -19,6 +19,9 @@
 [Color2]
 Color=24,178,24
 
+[Color2Intense]
+Color=84,255,84
+
 [Color3]
 Color=178,104,24

Comment 1 Jekyll Wu 2012-09-10 19:14:21 UTC

Thanks for reporting and investigating the problem, and sorry for my stupid mistake.

Will push the fix soon.

Comment 2 Jekyll Wu 2012-09-10 19:15:27 UTC

Git commit 3ef1c281d4b20610197d20ae2668395779431349 by Jekyll Wu.
Committed on 10/09/2012 at 20:58.
Pushed by jekyllwu into branch 'master'.

Re-add the "Color2Intense" entry in the BlackOnLightYellow colorscheme

That entry was accidentally removed in commit 8355cca
FIXED-IN: 4.9.2

M  +3    -0    data/color-schemes/BlackOnLightYellow.colorscheme

http://commits.kde.org/konsole/3ef1c281d4b20610197d20ae2668395779431349

Comment 3 Jekyll Wu 2012-09-10 19:17:36 UTC

Git commit f6456664f0f2aed9c677c1113aa2fa84b931070d by Jekyll Wu.
Committed on 10/09/2012 at 20:58.
Pushed by jekyllwu into branch 'KDE/4.9'.

Re-add the "Color2Intense" entry in the BlackOnLightYellow colorscheme

That entry was accidentally removed in commit 8355cca
FIXED-IN: 4.9.2
(cherry picked from commit 3ef1c281d4b20610197d20ae2668395779431349)

M  +3    -0    data/color-schemes/BlackOnLightYellow.colorscheme

http://commits.kde.org/konsole/f6456664f0f2aed9c677c1113aa2fa84b931070d

Comment 4 Leendert Meyer 2012-09-10 19:33:24 UTC

On Monday 10 September 2012 19:14:21 you wrote:
> https://bugs.kde.org/show_bug.cgi?id=306540
> 
> --- Comment #1 from Jekyll Wu <adaptee@gmail.com> ---
> Thanks for reporting and investigating the problem, and sorry for my stupid
> mistake.

Well, nobody is perfect. ;-) Thanks for the quick response.

> Will push the fix soon.

I noticed you already did. :-)

Looking forward to see it back in the 4.9.2 rpms.

O, BTW, maybe it is an idea to do a quick diff before a commit? ;-)

Thanks and regards,

Leendert Meyer