Bug 306451

Summary:	Usability issue: "Attach as tab to" menu can be empty
Product:	[Plasma] kwin	Reporter:	Jan <medhefgo>
Component:	window-tabbing	Assignee:	KWin default assignee <kwin-bugs-null>
Status:	RESOLVED FIXED
Severity:	wishlist
Priority:	NOR
Version First Reported In:	4.9.1
Target Milestone:	4.11
Platform:	Arch Linux
OS:	Linux
Latest Commit:	http://commits.kde.org/kde-workspace/f0d5e41ecd71eed013f68acafe159e43e26d3107	Version Fixed/Implemented In:	4.11
Sentry Crash Report:

Description Jan 2012-09-08 13:05:56 UTC

The "Attach as tab to" menu is empty when there is only one window open. This results in a ugly pixel displayed as the "menu" when using oxygen. The item should be disabled if there is nothing the window can be attached to or a disabled dummy entry should be inserted into the submenu to tell the user so.

On a related note: this item doesn't use the same capitalization rule as the other kwin menu items.

Reproducible: Always

Comment 1 Thomas Lübking 2012-09-09 12:55:14 UTC

En/Disabling the popup is no option since it's re/build when opened. It might be possible to force down the open if it's empty but that (on an active parent action) would seem a bug as well
-> dummy entry, but that (as well as Caps Change) can only happen for 4.10 due to i18n of user visible strings.

Proposal for a dummy entry?

Comment 2 Jan 2012-09-09 14:20:38 UTC

Maybe something like "No Window Available for Attaching"?

Comment 3 Thomas Lübking 2013-04-07 12:58:46 UTC

Git commit f0d5e41ecd71eed013f68acafe159e43e26d3107 by Thomas Lübking.
Committed on 23/03/2013 at 22:20.
Pushed by luebking into branch 'master'.

add dummy if no window for tab attach is available
FIXED-IN: 4.11
REVIEW: 109782

M  +2    -0    kwin/useractions.cpp

http://commits.kde.org/kde-workspace/f0d5e41ecd71eed013f68acafe159e43e26d3107