Summary: | autoraise raises inactive window under mouse when switching workspaces or closing active window | ||
---|---|---|---|
Product: | [Plasma] kwin | Reporter: | Michael Hohmuth <hohmuth> |
Component: | core | Assignee: | KWin default assignee <kwin-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | woebbeking |
Priority: | NOR | ||
Version: | git master | ||
Target Milestone: | 4.9.2 | ||
Platform: | openSUSE | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/kde-workspace/6d098c60a5b998b6eb23cd6a30ffce8858f0aa16 | Version Fixed In: | 4.9.2 |
Sentry Crash Report: | |||
Attachments: |
Proposed patch: predicate autoraise on moving mouse
Proposed patch v2: predicate autoraise on moving mouse |
Description
Michael Hohmuth
2012-09-05 07:20:25 UTC
Created attachment 73666 [details]
Proposed patch: predicate autoraise on moving mouse
No idea whether that's a regression (ie. how it behaved on 3.5) but feels wrong. Please move the check before the more expensive topClientOnDesktop() Do you have commit rights? Otherwise please provide a "git format-patch" so we can commit on your behalf. And thanks for the notice & patch, btw. Created attachment 73672 [details]
Proposed patch v2: predicate autoraise on moving mouse
Thanks for your quick feedback. Updated patch attached.
No, I do not have commit privileges.
Patch is fine and works @Martin: any comments from your side? (9/10, "no way" ;-) @Michael: Thanks again, ideally http://use git.reviewboard.kde.org to get future patches reviewed (if there will be such) only commit is that I will be very happy about that fix :-) And I'm quite sure this report is a duplicate, but I cannot find it Git commit 6d098c60a5b998b6eb23cd6a30ffce8858f0aa16 by Thomas Lübking, on behalf of Michael Hohmuth. Committed on 04/09/2012 at 23:36. Pushed by luebking into branch 'KDE/4.9'. Do not autoraise a window unless the mouse has been moved. Fixes unintended autoraises when switching workspaces. FIXED-IN: 4.9.2 M +2 -1 kwin/events.cpp http://commits.kde.org/kde-workspace/6d098c60a5b998b6eb23cd6a30ffce8858f0aa16 (In reply to comment #5) > only commit is that I will be very happy about that fix :-) And I'm quite > sure this report is a duplicate, but I cannot find it Isn't this 'related' to 92290? focus != raising I don't know whether there's an actual dupe. FTR: original bug #92290 lead to the introduction of the last_mouse_pos variable, last remaining part was about unhiding dropdowns (and similar windows) |