Bug 306193

Summary: desktop-file-validate fails on desktop files
Product: [Applications] digikam Reporter: nucleo <nucleo>
Component: Bundle-TarballAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: caulier.gilles
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: unspecified   
OS: Linux   
Latest Commit: http://commits.kde.org/kipi-plugins/e6970f4f2fe48c9f38fb25ca252cc2799d6674d0 Version Fixed In: 3.0.0
Sentry Crash Report:

Description nucleo 2012-09-03 12:17:42 UTC 
desktop-file-validate runs in %check section of digikam.spec for applications .desktop files.
But starting from digikam-2.9.0 it fails for kipiplugins.desktop.

Reproducible: Always

Actual Results:  
desktop-file-validate /builddir/build/BUILDROOT/digikam-2.9.0-1.fc19.x86_64/usr/share/applications/kde4/kipiplugins.desktop
/builddir/build/BUILDROOT/digikam-2.9.0-1.fc19.x86_64/usr/share/applications/kde4/kipiplugins.desktop: error: file contains group "KipiPlugins Entry", but groups extending the format should start with "X-"
Comment 1 caulier.gilles 2012-09-03 13:16:55 UTC 
Git commit 1d4d1ec3d6b2fb2737e90b0c071e641a8e51e285 by Gilles Caulier.
Committed on 03/09/2012 at 15:15.
Pushed by cgilles into branch 'development/2.0.0'.

use X- prefix with customized kipiplugins group of desktop file

M  +1    -1    libkipi/pluginloader.cpp

http://commits.kde.org/libkipi/1d4d1ec3d6b2fb2737e90b0c071e641a8e51e285

diff --git a/libkipi/pluginloader.cpp b/libkipi/pluginloader.cpp
index 8d30463..c5d0518 100644
--- a/libkipi/pluginloader.cpp
+++ b/libkipi/pluginloader.cpp
@@ -399,7 +399,7 @@ QString PluginLoader::kipiPluginsVersion() const
     QString ver                = i18n("unavailable");
     QString path               = KGlobal::dirs()->installPath("xdgdata-apps") + QString("kipiplugins.desktop");
     KDesktopFile desk(path);
-    QMap<QString, QString> map = desk.entryMap("KipiPlugins Entry");
+    QMap<QString, QString> map = desk.entryMap("X-KipiPlugins Entry");

     if (!map.isEmpty())
     {
Comment 2 caulier.gilles 2012-09-03 13:18:09 UTC 
Git commit e6970f4f2fe48c9f38fb25ca252cc2799d6674d0 by Gilles Caulier.
Committed on 03/09/2012 at 15:17.
Pushed by cgilles into branch 'development/3.0.0'.

use X- prefix with customized kipiplugins group of desktop file
FIXED-IN: 3.0.0

M  +1    -1    common/libkipiplugins/kipiplugins.desktop.cmake

http://commits.kde.org/kipi-plugins/e6970f4f2fe48c9f38fb25ca252cc2799d6674d0