| Summary: | Split out Useractions Menu from Workspace | ||
|---|---|---|---|
| Product: | [Plasma] kwin | Reporter: | Martin Flöser <mgraesslin> |
| Component: | core | Assignee: | Martin Flöser <mgraesslin> |
| Status: | RESOLVED FIXED | ||
| Severity: | task | CC: | kwin-bugs-null |
| Priority: | NOR | Flags: | mgraesslin:
ReviewRequest+
|
| Version: | git master | ||
| Target Milestone: | 4.10 | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| URL: | https://git.reviewboard.kde.org/r/106085/ | ||
| Latest Commit: | http://commits.kde.org/kde-workspace/acbfed1e564d5e6103988e4697da3127f42fd9ed | Version Fixed In: | 4.10 |
| Sentry Crash Report: | |||
|
Description
Martin Flöser
2012-08-26 18:35:04 UTC
Git commit acbfed1e564d5e6103988e4697da3127f42fd9ed by Martin Gräßlin. Committed on 19/08/2012 at 12:00. Pushed by graesslin into branch 'master'. Split the User Actions Menu out of Workspace All methods and variables related to the User Actions Menu (rmb window deco, Alt+F3) is moved out of the Workspace class into an own UserActionsMenu class. The class needs only a very small public interface containing methods to show the menu for a Client, closing the menu and discarding the menu. Everything else is actually private to the implementation which is one of the reasons why it makes sense to split the functionality out of the Workspace class. As a result the methods and variables have more sane names and the variable names are standardized. REVIEW: 106085 FIXED-IN: 4.10 M +4 -0 kwin/activation.cpp M +3 -2 kwin/composite.cpp M +2 -1 kwin/events.cpp M +517 -412 kwin/useractions.cpp A +255 -0 kwin/useractions.h [License: GPL (v2)] M +16 -88 kwin/workspace.cpp M +15 -52 kwin/workspace.h http://commits.kde.org/kde-workspace/acbfed1e564d5e6103988e4697da3127f42fd9ed |