| Summary: | Manual re-ordering of window tabs is erratic | ||
|---|---|---|---|
| Product: | [Plasma] Oxygen | Reporter: | Gilboa Davara <gilboad> |
| Component: | win deco | Assignee: | Hugo Pereira Da Costa <hugo.pereira.da.costa> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | hugo.pereira.da.costa, kwin-bugs-null, travisgevans |
| Priority: | NOR | Keywords: | regression |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/kde-workspace/e9b0b5548eb60affb417683eb23a1655e79114e6 | Version Fixed In: | 4.9.1 |
| Sentry Crash Report: | |||
| Attachments: |
Manual reordering movie.
updated patch |
||
|
Description
Gilboa Davara
2012-08-19 16:26:42 UTC
Created attachment 73307 [details]
Manual reordering movie.
tab before/behind seems to work (using the rmb buttons) so it's likely a problem in the tab before / behind invocation compared to the visual representation (could be my fault when porting the oxygen deco to the new API) OK, thanks for the update. Let me know if there's a patch / fix that you want me to test. - Gilboa Created attachment 73516 [details]
updated patch
Tested here and works fine.
It includes the patch proposed by Thomas and mentionned in the review board but extends it to
- make the visualization match the actual positionning
- fix some visualization issues.
@Gilboa Tell me if you get a chance to test the patch from comment #5 (possibly before KDE4.9.1 tagging, by thirsday) *** Bug 304998 has been marked as a duplicate of this bug. *** The only relevant additional change are the two swapped tabIndex calls, right? (i don't want to damage my git history even more ;-) @Thomas yes: - const int clickedIndex( tabIndexAt( position, false ) ); + const int clickedIndex( tabIndexAt( position, true ) ); (x2) So, will you include this in your review request and push ? Or do you want me to push full patch and discard your request ? I *will* commit the clean-up in any case (either in same patch or after yours) I'll first of all check the change and pass you a feedback. But it's your deco - commit & push whenever you feel like (ensure to close this bug so i see the push) "Ship It!" Might be matter of taste - both variants do not feel ideal to me. Git commit e9b0b5548eb60affb417683eb23a1655e79114e6 by Hugo Pereira Da Costa. Committed on 28/08/2012 at 09:26. Pushed by hpereiradacosta into branch 'master'. Fixed positioning of tabs when manually reordering with right mouse button Made 'drop target' animation consistent with where tab is actually dropped Cleanup code. M +19 -28 kwin/clients/oxygen/oxygenclient.cpp http://commits.kde.org/kde-workspace/e9b0b5548eb60affb417683eb23a1655e79114e6 Git commit 7e5368f6d02d9d34863cf5f5427141693d237ad4 by Hugo Pereira Da Costa. Committed on 28/08/2012 at 09:26. Pushed by hpereiradacosta into branch 'KDE/4.9'. Fixed positioning of tabs when manually reordering with right mouse button Made 'drop target' animation consistent with where tab is actually dropped Cleanup code. M +19 -28 kwin/clients/oxygen/oxygenclient.cpp http://commits.kde.org/kde-workspace/7e5368f6d02d9d34863cf5f5427141693d237ad4 That fixes it. Closing. Confirmed, fixed. Thanks for the fast fix! - Gilboa Is the fix included in 4.9.1? should be yes Working. Thanks. |