Bug 305362

Summary: patch add process info support on openbsd
Product: [Applications] konsole Reporter: Vadim Zhukov <persgray>
Component: generalAssignee: Konsole Developer <konsole-devel>
Status: RESOLVED FIXED    
Severity: wishlist    
Priority: NOR    
Version: 2.9   
Target Milestone: ---   
Platform: OpenBSD   
OS: OpenBSD   
Latest Commit: http://commits.kde.org/konsole/659d2c60aeeec00159074f14542737c4f26fe063 Version Fixed In: 4.10.0
Sentry Crash Report:
Attachments: BSDProcessInfo patch

Description Vadim Zhukov 2012-08-17 23:11:28 UTC 
ATM Konsole does not support gathering process information on OpenBSD. I've a patch adding such support; its previous version was send to konsole@kde.org directly but no replies so far.

Reproducible: Always

Steps to Reproduce:
1. Start Konsole on OpenBSD
Actual Results:  
There is no current process information in title bar.

Expected Results:  
Non-empty fields in title bar.

Patch will come in comments below.
Comment 1 Vadim Zhukov 2012-08-17 23:12:33 UTC 
Created attachment 73262 [details]
BSDProcessInfo patch
Comment 2 Jekyll Wu 2012-08-18 04:08:38 UTC 
Hi Vadim

Actually, I made a reply[1]  one week ago to the patch sent to the mailing list. Maybe it is because I only replied to the list and you are not subscribed ?

Anyway, please use reviewboard for non-trivial patch and fix the issue of TAB and extra spaces in this patch first.

[1] http://lists.kde.org/?l=konsole-devel&m=134476317128993&w=2
Comment 3 Vadim Zhukov 2012-08-18 11:08:58 UTC 
18.08.2012 8:08 пользователь "Jekyll Wu" <adaptee@gmail.com> написал:
>
> https://bugs.kde.org/show_bug.cgi?id=305362
>
> --- Comment #2 from Jekyll Wu <adaptee@gmail.com> ---
> Hi Vadim
>
> Actually, I made a reply[1]  one week ago to the patch sent to the mailing
> list. Maybe it is because I only replied to the list and you are not
subscribed
> ?

Yep. I've even checked mail list archive, but looks like too early. Sorry
for extra noise. :(

> Anyway, please use reviewboard for non-trivial patch and fix the issue of
TAB
> and extra spaces in this patch first.

Acknowledged, thanks. I'll follow these steps in a day our two and put link
to review here then.

> [1] http://lists.kde.org/?l=konsole-devel&m=134476317128993&w=2
Comment 4 Vadim Zhukov 2012-08-22 20:47:44 UTC 
Review here: https://reviewboard.kde.org/r/106129/
2moderators: please close this bug report with WILLNOTFIX or such.
Comment 5 Jekyll Wu 2012-10-17 20:25:56 UTC 
Git commit 659d2c60aeeec00159074f14542737c4f26fe063 by Jekyll Wu.
Committed on 17/10/2012 at 22:17.
Pushed by jekyllwu into branch 'master'.

Add the support of gathering process information on OpenBSD

Thanks to Vadim Zhukov for providing the patch
REVIEW: 106129

FIXED-IN: 4.10.0

M  +141  -2    src/ProcessInfo.cpp

http://commits.kde.org/konsole/659d2c60aeeec00159074f14542737c4f26fe063