Bug 305338

Summary:	Effect Information not included in Support Information
Product:	[Plasma] kwin	Reporter:	Martin Flöser <mgraesslin>
Component:	compositing	Assignee:	KWin default assignee <kwin-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	Flags:	mgraesslin: ReviewRequest+
Priority:	NOR
Version:	4.9.0
Target Milestone:	4.9.1
Platform:	unspecified
OS:	Linux
URL:	https://git.reviewboard.kde.org/r/105977/
Latest Commit:	http://commits.kde.org/kde-workspace/42aa9c80217f8f23a1ad3947ee1d8ba0748ad277	Version Fixed In:	4.9.1
Sentry Crash Report:

Description Martin Flöser 2012-08-17 15:53:01 UTC

Steps to reproduce:
1. qdbus org.kde.kwin /KWin supportInformation

Expected Result:
information about each individual effect are provided in the same way as for normal KWin options

Actual Result:
Only information about which effects are loaded and which are active are provided

Comment 1 Martin Flöser 2012-08-17 15:54:48 UTC

Git commit 42aa9c80217f8f23a1ad3947ee1d8ba0748ad277 by Martin Gräßlin.
Committed on 11/08/2012 at 11:24.
Pushed by graesslin into branch 'KDE/4.9'.

Effects can provide support information through properties

The supportInformation is extended to also read the properties
on all effects. In addition each effect can be queried just for
itself through D-Bus, e.g.:
qdbus org.kde.kwin /KWin supportInformationForEffect kwin4_effect_blur

All effects are extended to provide their configured and read
settings through properties. In some cases also important
runtime information is exposed.

REVIEW: 105977
FIXED-IN: 4.9.1

M  +24   -2    kwin/effects.cpp
M  +2    -1    kwin/effects.h
M  +5    -0    kwin/effects/blur/blur.cpp
M  +8    -0    kwin/effects/blur/blur.h
M  +47   -0    kwin/effects/coverswitch/coverswitch.h
M  +67   -0    kwin/effects/cube/cube.h
M  +21   -0    kwin/effects/cube/cubeslide.h
M  +13   -0    kwin/effects/dashboard/dashboard.h
M  +26   -0    kwin/effects/desktopgrid/desktopgrid.h
M  +5    -0    kwin/effects/dialogparent/dialogparent.h
M  +21   -0    kwin/effects/diminactive/diminactive.h
M  +5    -0    kwin/effects/fallapart/fallapart.h
M  +31   -0    kwin/effects/flipswitch/flipswitch.h
M  +14   -0    kwin/effects/glide/glide.h
M  +5    -0    kwin/effects/login/login.h
M  +6    -0    kwin/effects/logout/logout.h
M  +5    -0    kwin/effects/lookingglass/lookingglass.h
M  +5    -0    kwin/effects/magiclamp/magiclamp.h
M  +10   -0    kwin/effects/magnifier/magnifier.h
M  +10   -0    kwin/effects/mousemark/mousemark.h
M  +66   -0    kwin/effects/presentwindows/presentwindows.h
M  +9    -0    kwin/effects/resize/resize.h
M  +5    -0    kwin/effects/sheet/sheet.h
M  +31   -0    kwin/effects/showfps/showfps.h
M  +9    -0    kwin/effects/slidingpopups/slidingpopups.h
M  +18   -0    kwin/effects/thumbnailaside/thumbnailaside.h
M  +10   -0    kwin/effects/trackmouse/trackmouse.h
M  +49   -0    kwin/effects/translucency/translucency.h
M  +9    -0    kwin/effects/windowgeometry/windowgeometry.h
M  +65   -0    kwin/effects/wobblywindows/wobblywindows.h
M  +33   -0    kwin/effects/zoom/zoom.h
M  +4    -0    kwin/org.kde.KWin.xml
M  +7    -0    kwin/useractions.cpp
M  +6    -0    kwin/workspace.cpp
M  +1    -0    kwin/workspace.h

http://commits.kde.org/kde-workspace/42aa9c80217f8f23a1ad3947ee1d8ba0748ad277