Bug 305264

Summary:	Missing and bad strings in translation template (.spec files for scripts and scripted services)
Product:	[Applications] amarok	Reporter:	Eduard Gotwig <gotwig>
Component:	general	Assignee:	Amarok Developers <amarok-bugs-dist>
Status:	RESOLVED FIXED
Severity:	minor	CC:	matej, oskar.jauch, yurchor
Priority:	NOR	Keywords:	usability
Version:	2.8.0
Target Milestone:	2.8
Platform:	Compiled Sources
OS:	All
Latest Commit:	http://commits.kde.org/amarok/6f11b6d7376507ef79c16e08da6ee0fe0b5a48fa	Version Fixed In:	2.9
Sentry Crash Report:

Description Eduard Gotwig 2012-08-16 14:12:42 UTC

Amarok 2.6 is missing some strings in the translation template, so the user sees them just in English. Sometimes the translation template string is not appropriate for the use case.

See the affected strings in "Additional Information" below

Reproducible: Always

Steps to Reproduce:
1.Open Amarok
2.See untranslated strings
Actual Results:
You see untranslateable / untranslated strings

Expected Results:
See translateable strings

Cool Streams
List of some high quality radio streams
- Strings are missing in template

Free Music Charts
Free Music Charts from Darkerradio.com
- Strings are missing in template
- bad string for the template becouse the user already knows that the songs in that internet source are "Free Music Charts". Suggestion for the description: "From Darkerradio.com" OR "Powered by Darkerradio.com"

Last.fm: The social music revolution
- bad string for the template becouse the user already knows that the songs are from source are at Last.fm. Suggestion for the description: Simply remove "Last.fm:" in that case, or describe that service better. Suggestion 2. : "Share your favorite music titles with friends" or something like that.

Librifox.org
Search for free audio books from Librivox
- Strings are missing in template. Suggestion: Change the Tiitle to what it does offer: "Free Audio Books". Change the description to the service : "From Librivox.org" OR "Powered by Librivox.org"

All Script names and script descriptions are not translatable, but I think that is not a big deal, becouse only devs care about that..

Comment 1 Myriam Schweingruber 2012-08-16 18:21:35 UTC

A major bug certainly not, minor and part of it even wish. A major bug would prevent the user from using a major feature, which is clearly not the case.

Comment 2 Yuri Chornoivan 2012-08-16 19:55:54 UTC

There are two kinds of untranslatable strings:

1. Strings form .spec files. Ex.:
Name=Free Music Charts
Comment=Listen to the Darkerradio.com Free Music Charts

These strings are shown in Script manager dialog. They can be extracted, translated and merged by scripty in a usual way for .desktop files:

Name=Free Music Charts
Name[uk]=Вільні музичні чарти
Comment=Listen to the Darkerradio.com Free Music Charts
Comment[uk]=Прослуховування вільних музичних чартів з Darkerradio.com

2. Strings from .js files. Ex.:

service_name = "Free Music Charts";
html = "<div style=\"background-color:#e6f3ff; height: 100%;\"><div style=\"background-color:#aacef3;\"><center><b>Free Music Charts</b></center></div><br/>The rules for the Darkerradio.com Free Music Charts are quite simple: the best 15 songs from the last month and five new ones are the candidates for the next voting. Only open music is allowed to take part, since February 2009 a song can stay in the charts for a time of six months max. You have up to five votes.<br/><br/>You can cast your votes by going to the menu bar: <i>Tools &rarr; Free Music Charts Voting</i></div>";

These strings are shown on Media pane. They should be wrapped into i18n and extracted in a way that is used for kate scripts.

Comment 3 Oskar Jauch 2013-12-03 13:57:02 UTC

Still reproducible with Amarok 2.8

Comment 4 Myriam Schweingruber 2013-12-03 14:14:47 UTC

Since the Free Music Charts do not exist anymore, does this still apply to the other two, namely last.fm and Librivox?

Comment 5 Oskar Jauch 2013-12-03 14:19:21 UTC

The last.fm string is translated but not the Librivox string.

Comment 6 Yuri Chornoivan 2013-12-03 19:00:11 UTC

A partial fix (just for .spec files) is proposed here:

https://git.reviewboard.kde.org/r/114282/

Comment 7 Yuri Chornoivan 2013-12-07 17:53:48 UTC

Git commit 6f11b6d7376507ef79c16e08da6ee0fe0b5a48fa by Yuri Chornoivan.
Committed on 07/12/2013 at 17:53.
Pushed by yurchor into branch 'master'.

Make the scripts translatable through KDE translation system

REVIEW: 114282
FIXED-IN: 2.9

M  +7    -1    src/scripts/librivox_service/CMakeLists.txt
R  +0    -0    src/scripts/librivox_service/script.desktop [from: src/scripts/librivox_service/script.spec - 100% similarity]
M  +7    -1    src/scripts/lyrics_lyricwiki/CMakeLists.txt
R  +0    -0    src/scripts/lyrics_lyricwiki/script.desktop [from: src/scripts/lyrics_lyricwiki/script.spec - 100% similarity]
M  +7    -1    src/scripts/radio_station_service/CMakeLists.txt
R  +0    -0    src/scripts/radio_station_service/script.desktop [from: src/scripts/radio_station_service/script.spec - 100% similarity]
M  +8    -1    src/scripts/script_console/CMakeLists.txt
R  +0    -0    src/scripts/script_console/script.desktop [from: src/scripts/script_console/script.spec - 100% similarity]

http://commits.kde.org/amarok/6f11b6d7376507ef79c16e08da6ee0fe0b5a48fa

Comment 8 Myriam Schweingruber 2014-08-13 21:12:05 UTC

Fixed by commit http://commits.kde.org/amarok/6f11b6d7376507ef79c16e08da6ee0fe0b5a48fa