| Summary: | Untranslated strings in "Order by" and "Additional Information" menu items | ||
|---|---|---|---|
| Product: | [Applications] dolphin | Reporter: | Luigi Toscano <luigi.toscano> |
| Component: | general | Assignee: | Frank Reininghaus <frank78ac> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | aacid, mmenaz |
| Priority: | NOR | ||
| Version: | 2.1 | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/kde-baseapps/1e289d5eb022cd51ed87116290c6f2c22f0c01a1 | Version Fixed In: | 4.9.1 |
| Sentry Crash Report: | |||
| Attachments: | Image showing the problem | ||
|
Description
Luigi Toscano
2012-08-15 23:35:42 UTC
Created attachment 73201 [details]
Image showing the problem
Bugfix at https://git.reviewboard.kde.org/r/106049/ It's sad this used to work at 4.8 and broke for 4.9, would be cool if you investigated what happened so it stooped working Git commit 199fabbaa8d8a12fb49e4c9922c38ec8b033923c by Albert Astals Cid. Committed on 16/08/2012 at 22:27. Pushed by aacid into branch 'KDE/4.9'. Fix translations not showing in the Sort by and Additional Information submenus Acked by Frank REVIEW: 106049 FIXED-IN: 4.9.1 M +3 -3 dolphin/src/kitemviews/kfileitemmodel.cpp http://commits.kde.org/kde-baseapps/199fabbaa8d8a12fb49e4c9922c38ec8b033923c Git commit 1e289d5eb022cd51ed87116290c6f2c22f0c01a1 by Albert Astals Cid. Committed on 16/08/2012 at 22:27. Pushed by aacid into branch 'master'. Fix translations not showing in the Sort by and Additional Information submenus Acked by Frank REVIEW: 106049 FIXED-IN: 4.9.1 (cherry picked from commit 199fabbaa8d8a12fb49e4c9922c38ec8b033923c) M +3 -3 dolphin/src/kitemviews/kfileitemmodel.cpp http://commits.kde.org/kde-baseapps/1e289d5eb022cd51ed87116290c6f2c22f0c01a1 Git commit 168d0511c754008cc679589566d961beb9f6cc10 by Frank Reininghaus. Committed on 24/08/2012 at 18:51. Pushed by freininghaus into branch 'KDE/4.9'. Fix regression that caused "(I18N_EMPTY_MESSAGE)" sub menus in menus For top-level roles like "Name" and "Size", the group translation is 0. In that case, the "group" member of the corresponding RoleInfo struct must be an empty string. This is expected by the code which generates Dolphin's menus, which group the top-level roles into a sub menu with the name "(I18N_EMPTY_MESSAGE)" otherwise. This is a recent regression caused by 199fabbaa8d8a12fb49e4c9922c38ec8b033923c. Thanks to Christoph Feck for investigating this issue! M +8 -1 dolphin/src/kitemviews/kfileitemmodel.cpp http://commits.kde.org/kde-baseapps/168d0511c754008cc679589566d961beb9f6cc10 Git commit ee63c6c719a650795051d5ad1ecc01856853d254 by Frank Reininghaus. Committed on 24/08/2012 at 18:51. Pushed by freininghaus into branch 'master'. Fix regression that caused "(I18N_EMPTY_MESSAGE)" sub menus in menus For top-level roles like "Name" and "Size", the group translation is 0. In that case, the "group" member of the corresponding RoleInfo struct must be an empty string. This is expected by the code which generates Dolphin's menus, which group the top-level roles into a sub menu with the name "(I18N_EMPTY_MESSAGE)" otherwise. This is a recent regression caused by 199fabbaa8d8a12fb49e4c9922c38ec8b033923c. Thanks to Christoph Feck for investigating this issue! (cherry picked from commit 168d0511c754008cc679589566d961beb9f6cc10) M +8 -1 dolphin/src/kitemviews/kfileitemmodel.cpp http://commits.kde.org/kde-baseapps/ee63c6c719a650795051d5ad1ecc01856853d254 |