Bug 305203

Summary: saved playlists get re-added to the main playlist after rename + <return>
Product: [Applications] amarok Reporter: Alan Ezust <alan.ezust>
Component: Playlists/Saved PlaylistsAssignee: Amarok Bugs <amarok-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: bart.cerneels, matej
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: 2.7   
Platform: Debian testing   
OS: Linux   
Latest Commit: http://commits.kde.org/amarok/9f48fbe617a6908d14d6f221c8ed6472316c674b Version Fixed/Implemented In: 2.7
Sentry Crash Report:

Description Alan Ezust 2012-08-15 15:09:00 UTC 
After a "save playlist" or if I make an edit trigger on the name of the playlist, I am able to change the name of it, but as soon as I hit return, it adds the entire contents of the saved playlist to the main playlist. 
Basically, the return key is not properly consumed while one is editing the name of the playlist.
I am using amarok 2.5-git pulled from git on august 8. c4eb51e0581f8fe354958ab840d3c4c69c02096f

This also happens if I just rename a playlist without saving a new one.


Reproducible: Always

Steps to Reproduce:
1. Save a playlist
2. Go to the entry in the playlists tree and rename it to something else
3. hit return when you are done. 
notice that the saved playlist has been added to your main playlist.


Actual Results:  
my main playlist doubled in size and got lots of duplicates.

Expected Results:  
nothing gets added to my main playlist when I rename a saved playlist.
Comment 1 Bart Cerneels 2012-08-16 12:01:04 UTC 
Git commit 9f48fbe617a6908d14d6f221c8ed6472316c674b by Bart Cerneels.
Committed on 16/08/2012 at 09:17.
Pushed by shanachie into branch 'master'.

Don't append when enter in playlist name edit.

I suspect a Qt bug here. Why doesn't the delegate consume the enter press?
FIXED-IN: 2.7

M  +12   -3    src/browsers/playlistbrowser/PlaylistBrowserView.cpp

http://commits.kde.org/amarok/9f48fbe617a6908d14d6f221c8ed6472316c674b