Bug 304775

Summary:	Multiple red 'X' icons/buttons are shown in the KMessageWidget below the location bar when errors occur
Product:	[Applications] dolphin	Reporter:	Ondrej Machulda <Ondrej.Machulda>
Component:	general	Assignee:	Dolphin Bug Assignee <dolphin-bugs-null>
Status:	RESOLVED FIXED
Severity:	minor	CC:	agateau, ejeggleston, m.wege
Priority:	NOR
Version:	2.1
Target Milestone:	---
Platform:	Gentoo Packages
OS:	Linux
URL:	https://dl.dropbox.com/u/15226372/screenshots/doplhin-icons-annotate.png
Latest Commit:	http://commits.kde.org/kdelibs/c8264896312e244e028be291dc390363d3aad843	Version Fixed In:	4.11.0
Sentry Crash Report:
Attachments:	Screenshot showing the three icons

Description Ondrej Machulda 2012-08-08 09:26:44 UTC

When error during opening a folder occurs, the error message is shown at the top of the window. 

In this moment, there are shown THREE (!) "X" icons, each with different look, two of them having same meaning (buttons to close or cancel something) and one is just design icon - but is not recognizable from the buttons.

Reproducible: Always

Comment 1 Ondrej Machulda 2012-08-08 09:27:37 UTC

Created attachment 73043 [details]
Screenshot showing the three icons

Comment 2 Frank Reininghaus 2012-08-08 09:37:46 UTC

Thanks for the bug report! I do not get the "X" in the status bar, but I agree that showing just two in the message widget is not optimal either. We should probably use a different icon in the top-left corner.

Comment 3 Jekyll Wu 2012-08-13 07:56:34 UTC

That message under the address bar is provided by KMessageWidget (the KMessageWidget::Error variant). Not sure whether that can be improved from the dolphin side.

Comment 4 Jeroen van Meeuwen (Kolab Systems) 2012-08-24 16:19:52 UTC

Resetting assignee to default as per bug #305719

Comment 5 Frank Reininghaus 2013-01-10 07:27:28 UTC

*** Bug 312991 has been marked as a duplicate of this bug. ***

Comment 6 Aurelien Gateau 2013-05-15 13:54:10 UTC

Git commit c8264896312e244e028be291dc390363d3aad843 by Aurélien Gâteau.
Committed on 06/05/2013 at 17:40.
Pushed by gateau into branch 'master'.

KMessageWidget: Hide decoration icon by default, add an "icon" property

This avoids confusion between the decoration icon and the close button,
especially when type is KMessageWidget::Error. This happens for example
with Dolphin when it fails to connect to a remote host.

This change also has the nice side-effect of leaving more space for the
widget text by default, but makes it possible for developers to provide
more meaningful icons when necessary.
REVIEW: 110327
FIXED-IN: 4.11.0

M  +20   -9    kdeui/widgets/kmessagewidget.cpp
M  +13   -0    kdeui/widgets/kmessagewidget.h

http://commits.kde.org/kdelibs/c8264896312e244e028be291dc390363d3aad843

Comment 7 Frank Reininghaus 2013-06-26 20:20:11 UTC

*** Bug 321653 has been marked as a duplicate of this bug. ***