Bug 304589

Summary:	mouse middle click on a location in the places icon should open it in a new tab (feature wish)
Product:	[Unmaintained] kfile	Reporter:	Frederico Valente <fmg.valente>
Component:	kurlnavigator	Assignee:	kdelibs bugs <kdelibs-bugs-null>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	AndyKluger, frank78ac, kde, richard.llom
Priority:	NOR
Version First Reported In:	4.11.4
Target Milestone:	---
Platform:	Fedora RPMs
OS:	Linux
Latest Commit:	https://commits.kde.org/kio/7dd46685bed7ec54462be6d2a9514084f5a927d2	Version Fixed In:
Sentry Crash Report:

Description Frederico Valente 2012-08-05 02:56:09 UTC

When the places panel is disabled, an icon for it appears on the left side of the directory breadcrumb.
Clicking the icon shows the locations from "places". A left mouse click  in an entry from the appearing menu takes us, as expected, to the corresponding location. I was expecting that a middle mouse click would open the location on a new tab as it happens when we do so on a directory. However, that does not seem to happen. To do so can be very handy when working with external drives, moving files, etc. Plus it is somewhat inconsistent with the rest of dolphin's behavior, where the middle click will open stuff in a new tab.


Reproducible: Always

Steps to Reproduce:
1.Disable places panel
2.click on places icon on the left of the breadcrumb
3.middle click on one of the locations

Actual Results:  
Nothing happens

Expected Results:  
new tab opens on the corresponding location

Comment 1 Frank Reininghaus 2012-08-06 09:21:54 UTC

Thanks for the report! I agree that this would make sense.

Comment 2 Jeroen van Meeuwen (Kolab Systems) 2012-08-24 16:18:31 UTC

Resetting assignee to default as per bug #305719

Comment 3 Richard Llom 2013-12-11 08:56:11 UTC

+1
related feature: bug 280571

Comment 4 Frank Reininghaus 2013-12-11 09:28:04 UTC

I think that, just like bug 280571, this can only be solved inside KUrlNavigator/KUrlNavigatorPlacesSelector. Dolphin does listen to KUrlNavigator's "tabRequested(KUrl)" signal already (can be tested by middle-clicking a "breadcrumb button"), so to implement this wish, KUrlNavigator must emit that signal also when middle-clicking a location in the "Places" menu.

Comment 5 Richard Llom 2013-12-27 23:13:15 UTC

Hello, I just found out that middle click for opening in new background tab actually works in v 4.11.3. However, ctrl+click does not.

Comment 6 AndyKluger 2017-08-18 16:10:33 UTC

I think the product should be changed to Dolphin, right? And maybe assignee -> Dolphin Bug Assignee (dolphin-bugs-null@kde.org)?

Comment 7 Kai Uwe Broulik 2017-08-24 14:15:21 UTC

Patches:
https://phabricator.kde.org/D7512 (for the button)
https://phabricator.kde.org/D7513 (for items in the menu)

Comment 8 Kai Uwe Broulik 2017-08-25 08:50:10 UTC

Git commit 027576183f9487910a5acbb762d049c4713bcff7 by Kai Uwe Broulik.
Committed on 25/08/2017 at 08:48.
Pushed by broulik into branch 'master'.

[KUrlNavigator] Emit tabRequested when places selector is middle-clicked

This makes it consistent with the breadcrumbs that also request a new tab when middle-clicked

Differential Revision: https://phabricator.kde.org/D7512

M  +2    -0    src/filewidgets/kurlnavigator.cpp
M  +11   -0    src/filewidgets/kurlnavigatorplacesselector.cpp
M  +7    -0    src/filewidgets/kurlnavigatorplacesselector_p.h

https://commits.kde.org/kio/027576183f9487910a5acbb762d049c4713bcff7

Comment 9 Kai Uwe Broulik 2017-08-25 08:50:14 UTC

Git commit 7dd46685bed7ec54462be6d2a9514084f5a927d2 by Kai Uwe Broulik.
Committed on 25/08/2017 at 08:49.
Pushed by broulik into branch 'master'.

[KUrlNavigator] Emit tabRequested when place in menu is middle-clicked

Differential Revision: https://phabricator.kde.org/D7513

M  +22   -0    src/filewidgets/kurlnavigatorplacesselector.cpp
M  +2    -0    src/filewidgets/kurlnavigatorplacesselector_p.h

https://commits.kde.org/kio/7dd46685bed7ec54462be6d2a9514084f5a927d2