| Summary: | Dolphin crashes when minimizing window before finishing file renaming [ KStandardItemListWidget::closeRoleEditor] | ||
|---|---|---|---|
| Product: | [Applications] dolphin | Reporter: | Janek Bevendorff <kde> |
| Component: | general | Assignee: | Dolphin Bug Assignee <dolphin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | russianneuromancer |
| Priority: | NOR | ||
| Version: | 2.1 | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/kde-baseapps/a9c2bdc3b53955693e716bbab58c318fe25bdc9b | Version Fixed In: | 4.9.1 |
| Sentry Crash Report: | |||
|
Description
Janek Bevendorff
2012-08-03 22:36:36 UTC
Actually, Dolphin crashes when hitting ANY button before finishing the renaming action properly. This also applies to toolbar buttons, not only buttons on the window frame. Thanks for the bug report! Looks like we are trying to dereference the dangling pointer m_roleEditor in KStandardItemListWidget::closeRoleEditor(). Resetting assignee to default as per bug #305719 Git commit a9c2bdc3b53955693e716bbab58c318fe25bdc9b by Frank Reininghaus. Committed on 24/08/2012 at 23:21. Pushed by freininghaus into branch 'KDE/4.9'. Do not crash when finishing inline renaming in unusual ways The crash was caused by a null pointer dereference when, e.g., minimizing Dolphin. The root cause was that KStandardItemListWidget::closeRoleEditor() was called twice: once when the role editor loses focus, and once again when the window is resized. After m_roleEditor was set to 0, the second call dereferenced this null pointer. I think the best solution is to disconnect from the role editor's signals when the editor is not needed any more by the KStandardItemListWidget. FIXED-IN: 4.9.1 M +10 -0 dolphin/src/kitemviews/kstandarditemlistwidget.cpp http://commits.kde.org/kde-baseapps/a9c2bdc3b53955693e716bbab58c318fe25bdc9b Git commit a3c1c748656e0fe3c34a8bfc0c7a2cc7b17d3a1c by Frank Reininghaus. Committed on 24/08/2012 at 23:21. Pushed by freininghaus into branch 'master'. Do not crash when finishing inline renaming in unusual ways The crash was caused by a null pointer dereference when, e.g., minimizing Dolphin. The root cause was that KStandardItemListWidget::closeRoleEditor() was called twice: once when the role editor loses focus, and once again when the window is resized. After m_roleEditor was set to 0, the second call dereferenced this null pointer. I think the best solution is to disconnect from the role editor's signals when the editor is not needed any more by the KStandardItemListWidget. (cherry picked from commit a9c2bdc3b53955693e716bbab58c318fe25bdc9b) M +10 -0 dolphin/src/kitemviews/kstandarditemlistwidget.cpp http://commits.kde.org/kde-baseapps/a3c1c748656e0fe3c34a8bfc0c7a2cc7b17d3a1c |