Bug 304387

Summary:	Let KGet determine download location
Product:	[Unmaintained] rekonq	Reporter:	Michael Reiher <redm>
Component:	general	Assignee:	Andrea Diamantini <adjam7>
Status:	RESOLVED FIXED
Severity:	wishlist
Priority:	NOR
Version:	1.0
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:	http://commits.kde.org/rekonq/5a5b8f01c699ec16a82f07b436433dc4e73e4f1b	Version Fixed In:
Sentry Crash Report:

Description Michael Reiher 2012-08-01 17:59:27 UTC

If KGet integration is enabled rekonq should not ask me where to save a file to download, but let KGet do this. This is also how it work in Konqueror and what makes most sense to me: if you use a download manager, let it do the job.

The background is that in KGet you can create groups of files with predefined download locations. And based on file extension KGet then automatically picks a group and thus a location where to download a file. You get a dialog where you can switch the group if you want, but usually all you have to do is click Ok. Very convenient.

So, without knowing the details it seems that rekonq tells KGet "download this file to that location", where the preferred way is to just say "download this file" and let KGet do the rest.

Reproducible: Always

Comment 1 Andrea Diamantini 2012-08-15 13:59:59 UTC

Right, rekonq says KGet where downloading files. I was not aware about this kget feature and you're the first one pointing me out about it.
Trying to fix in time for 1.1

Comment 2 Michael Reiher 2012-08-15 14:05:46 UTC

Cool, thanks!

Comment 3 Andrea Diamantini 2013-02-26 17:51:11 UTC

Git commit 5a5b8f01c699ec16a82f07b436433dc4e73e4f1b by Andrea Diamantini.
Committed on 26/02/2013 at 18:42.
Pushed by adjam into branch 'master'.

If KGet is selected as download manager, let it decide destination

WARNING:
to let this work, we had to change rekonq behavior, NOT
remembering in rekonq downloads history what has been downloaded
via KGet
CCMAIL: ericsbinaryworld@gmail.com

M  +17   -41   src/download/downloadmanager.cpp
M  +0    -1    src/download/downloadmanager.h

http://commits.kde.org/rekonq/5a5b8f01c699ec16a82f07b436433dc4e73e4f1b

Comment 4 Michael Reiher 2013-03-05 21:43:40 UTC

First of, thanks for taking care of this. Though, when trying it out I noticed that this is not quite what I had in mind (and what Konqueror uses). What I meant is the dialog you get with the showNewTransferDialog() function of the DBUS interface. Could you use this one instead of addTransfer()?

This way you get a nice compact dialog with the preselected proper download group (and path) and the chance to select a different group (or manually change the location), instead of the plain file dialog.

Sorry, found this out just now.

Comment 5 Andrea Diamantini 2013-03-05 22:23:32 UTC

Hi Michael,
I'll try to take care in next release cycle.

Regards,


2013/3/5 Michael Reiher <redm@gmx.de>

> https://bugs.kde.org/show_bug.cgi?id=304387
>
> --- Comment #4 from Michael Reiher <redm@gmx.de> ---
> First of, thanks for taking care of this. Though, when trying it out I
> noticed
> that this is not quite what I had in mind (and what Konqueror uses). What I
> meant is the dialog you get with the showNewTransferDialog() function of
> the
> DBUS interface. Could you use this one instead of addTransfer()?
>
> This way you get a nice compact dialog with the preselected proper download
> group (and path) and the chance to select a different group (or manually
> change
> the location), instead of the plain file dialog.
>
> Sorry, found this out just now.
>
> --
> You are receiving this mail because:
> You are the assignee for the bug.
>

Comment 6 Christoph Feck 2013-04-21 11:52:10 UTC

Should Michael file a new entry about the new behavior?