| Summary: | Spaces converted to + when using web shortcuts | ||
|---|---|---|---|
| Product: | [Plasma] krunner | Reporter: | Adrián Chaves (Gallaecio) <adrian> |
| Component: | webshortcuts | Assignee: | Alexander Lohnau <alexander.lohnau> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | alexander.lohnau, de.meyer.maarten, nate |
| Priority: | NOR | ||
| Version: | 4.8.4 | ||
| Target Milestone: | --- | ||
| Platform: | Chakra | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/frameworks/kio/commit/759624d03bf7a0358ba07422655cb3ab873d7e4c | Version Fixed In: | 5.72 |
|
Description
Adrián Chaves (Gallaecio)
2012-07-30 10:30:03 UTC
This is not a problem in krunner but in the shortcut. Rekonq was not using the correct implementation, but in the next version it will also have this problem. Could you give an real example of a shortcut that has this problem? http://en.wikipedia.org/wiki/\{@} If you call the web shortcut “test”, you can check “test:KDE Plasma Workspaces” both from Rekonq and KRunner. From Rekonq, it opens “http://en.wikipedia.org/wiki/KDE_Plasma_Workspaces”. From KRunner, it opens “http://en.wikipedia.org/wiki/KDE+Plasma+Workspaces” instead. You are not using the wikipedia search function. http://en.wikipedia.org/wiki/Special:Search?search=\{@}&go=Go works as it should. Again I have changed rekonq to use the same implementation as konqueror and krunner. Your test example will no longer work in future versions. Not converting spaces to + could break a lot of shortcuts. Then, let this be a feature request for an alternative key (\{#}?) that does not replace spaces with plus signs.
Just so this does not sound like a useless request, I though I would explain why Rekonq 2.3.0 has broken my workflow a bit.
I work on MediaWiki sites that, for performance reasons (I guess), do not provide the Special:Search page. That is, you cannot search those wikis. So, instead, I use the syntax “wiki:Page Name” to open a given page.
This used to work, not from KRunner, but it did from Rekonq directly. Since MediaWiki sites replace spaces with _ automatically, the URL was loaded properly.
Now that spaces are replaced by + signs, and since there are no alternative keywords to \{@} that either do not replace spaces or that transform them into _, I cannot use the same workflow anymore.
Instead, I have to insert the _ symbols instead of spaces myself. This is something trivial, but not much confortable. Just imagine you had to use a + sign instead of a space when searching.
Anyway, I will start using _ instead of whitespaces and try to get used to it.
A small workaround you can use: http://en.wikipedia.org/wiki/\{1} \{2} \{3} \{4} \{5} And so on for the maximum amount of arguments you will ever need. I know, it is not a clean solution. But it works :) A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kio/-/merge_requests/65 Git commit 759624d03bf7a0358ba07422655cb3ab873d7e4c by Alexander Lohnau. Committed on 26/06/2020 at 03:39. Pushed by alex into branch 'master'. Also encode space characters for webshortcut URLs Related: bug 423255 FIXED-IN: 5.72 M +1 -1 autotests/kurifiltertest.cpp M +2 -3 src/urifilters/ikws/kuriikwsfiltereng.cpp https://invent.kde.org/frameworks/kio/commit/759624d03bf7a0358ba07422655cb3ab873d7e4c |