Summary: | Moving users between groups using mouse drag is difficult as contact list does not scroll | ||
---|---|---|---|
Product: | [Unmaintained] telepathy | Reporter: | Venky <venkythegeek> |
Component: | contactlist | Assignee: | Telepathy Bugs <kde-telepathy-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | hena18, kde, mklapetek |
Priority: | NOR | Keywords: | junior-jobs |
Version: | 0.4.0 | ||
Target Milestone: | 0.6-next | ||
Platform: | Chakra | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/telepathy-contact-list/5e84289ecd5a2433e75d8ed85c99188564c6796c | Version Fixed In: | 0.6.0 |
Sentry Crash Report: | |||
Attachments: |
I tried to make a pseudo code of how to proceed it ..
Tried to set the attribute DrapDrop How is this? tried to set the autoscroll property |
Description
Venky
2012-07-26 14:37:50 UTC
Confirmed. To fix see: http://qt-project.org/doc/qt-4.8/qabstractitemview.html#autoScroll-prop Marking as junior-job Created attachment 76063 [details]
I tried to make a pseudo code of how to proceed it ..
It is just a pseudo code of how to use qabstractview and not the complete code.
Regards
Uhm...what did you do exactly? I'm marking it for 0.6, if no junior developer takes it, I'll fix it before the release. @Martin : Hey 1 :) I just tried to put a few attributes which may be useful for the given bug .Could you explain further how to proceed on it ? Regards Sure. As David pointed out in comment #1, you need to set the autoScroll property[1] on the list view, which is in contact-list-widget.cpp. In the constructor you will find lots of properties being set, so just add one more and you're done. [1] - http://qt-project.org/doc/qt-4.8/qabstractitemview.html#autoScroll-prop I found contact-list.c in kde-telepathy-glib but not contact-list-widget.cpp (in root) could you please specify its location? It's in ktp-contact-list, found at http://quickgit.kde.org/?p=ktp-contact-list.git Created attachment 76338 [details]
Tried to set the attribute DrapDrop
static void
example_contact_list_init (ExampleContactList *self)
{
self->priv=QAbstractItemView::DragDrop;
//QAbstractItemView::DragDrop;}
Does it even compile for you? ;) Created attachment 76341 [details]
How is this?
@Martin I am just a beginner :-P I know and that's perfectly fine. However I'd suggest you get more familiar with general developing first - like compiling things, understanding functions, return types, classes structures, testing your changes and so on. That will give you truly huge boost for fixing stuff in KDE. As for your patch...well, getting closer, but still not there. Revert all you have done and just follow what is said in comment #6 :) okay ..Thank you for your time :-) :D Created attachment 76439 [details]
tried to set the autoscroll property
Errr ... Could you upload a diff to https://git.reviewboard.kde.org/ instead? On Sun, Jan 13, 2013 at 9:09 PM, heena <hena18@rocketmail.com> wrote: > https://bugs.kde.org/show_bug.cgi?id=304094 > > --- Comment #15 from heena <hena18@rocketmail.com> --- > Created attachment 76439 [details] > --> https://bugs.kde.org/attachment.cgi?id=76439&action=edit > tried to set the autoscroll property > > -- > You are receiving this mail because: > You are the assignee for the bug. > _______________________________________________ > Kde-telepathy-bugs mailing list > Kde-telepathy-bugs@kde.org > https://mail.kde.org/mailman/listinfo/kde-telepathy-bugs Before trying to do that, please be sure that things compile. That code attached will not. I would recommend you spend some time getting used to building various applications from source, and going through some C++ tutorials for a while. Git commit 5e84289ecd5a2433e75d8ed85c99188564c6796c by David Edmundson. Committed on 22/01/2013 at 14:11. Pushed by davidedmundson into branch 'master'. Scroll when dragging contacts As we override the drag+drop of the contact list the default scrolling in drag move event was not called. This patch fixes that Reviewed-by: Martin Klapetek M +1 -0 contact-list-widget.cpp http://commits.kde.org/telepathy-contact-list/5e84289ecd5a2433e75d8ed85c99188564c6796c |