Summary: | oxygen-gtk theme leads to unreadable menus in guitarix | ||
---|---|---|---|
Product: | [Plasma] Oxygen | Reporter: | Ian Malone <ibmalone> |
Component: | gtk2-engine | Assignee: | Hugo Pereira Da Costa <hugo.pereira.da.costa> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | b7.10110111, hugo.pereira.da.costa, nucleo, web |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Fedora RPMs | ||
OS: | Linux | ||
URL: | https://picasaweb.google.com/lh/photo/MB4K_E3UVmO3J4OrNI6nr-PFHzJ9cFFhbUJUYSJLZfM?feat=directlink | ||
Latest Commit: | Version Fixed In: |
Description
Ian Malone
2012-07-25 22:05:22 UTC
it is indeed oxygen gtk bug that we do not honour curstom colors for the background in several places, which results in the bug you mention. Will investigate I guess in the meanwhile you can use the "default" theme ? (In general I really don't like themed applications as this goes against all efforts of consistency across desktop ...) In fact, I have almost the same menu look with QtCurve: http://imgur.com/k0PDx . The only difference is the menu bar, which is dark here. Not sure if we really want to follow app-set custom window background colors. @Ruslan, I agree that not respecting the custom colors at all might be a solution, but then we must make it consistently, that is, not respect the foreground color change either. The fact that the current colors are "hybrid" is what causes the problem. Whatever we decide, there are changes involved on our side. In the end I'm not sure that it is more difficult to just honour the custom background (as we do for main window already), though this depends on how it is set by the application. I'll have a look Hugo Thanks. Indeed QtCurve has the same problem, but clearlook does not. I don't really think it's critical to the app to theme the menu-bar, but the default skin is one of the affected ones (and oxygen-gtk is Fedora's default gtk on KDE theme), so the source of the problem isn't immediately obvious. @Ian can you post a screenshot of how the applications (notably menus) look with clearlooks ? (to make sure I understand things right) Thanks in adv Hugo Hi, picture with clearlooks: https://picasaweb.google.com/lh/photo/jap3Spa98MbNltjFJz9orOPFHzJ9cFFhbUJUYSJLZfM?feat=directlink That's also how it appears in gnome. @Ruslan Patch at: http://pastebin.com/xUHHeZD1 Fixes the issue. It is rather simple, so what do you think ? Basically it overwrites our Palette settings with whatever "Style->..." contains. Hopefully this does not break other things, provided that our default (on-fly generated) gtkrc is not broken. Only drawback is that it slows down a bit color lookup at each rendering (though I have not seen any visible change) Now I must say, well, to me the app simply looks plain ugly, themed or not :( not sure it is worth the effort ... PS: the mandatory screenshot: http://wstaw.org/m/2012/07/26/plasma-desktopRX3774.png Looks good enough. Slowdown should be negligible, so I think this can be pushed. Git commit 0e5335e3cbc2ea0aadf9d16a794acae8094f467e by Hugo Pereira Da Costa. Committed on 26/07/2012 at 18:38. Pushed by hpereiradacosta into branch 'master'. oxygenstyle: use color provided by options when available when rendering menu background. oxygenstylewrapper: use color provided by style to render menubar and menu background M +1 -1 src/oxygenstyle.cpp M +10 -1 src/oxygenstylewrapper.cpp http://commits.kde.org/oxygen-gtk/0e5335e3cbc2ea0aadf9d16a794acae8094f467e Git commit 2d1e8ce65b81404936cddfe669e3a9b8b03d59ad by Hugo Pereira Da Costa. Committed on 26/07/2012 at 18:38. Pushed by hpereiradacosta into branch '1.3'. oxygenstyle: use color provided by options when available when rendering menu background. oxygenstylewrapper: use color provided by style to render menubar and menu background M +1 -1 src/oxygenstyle.cpp M +10 -1 src/oxygenstylewrapper.cpp http://commits.kde.org/oxygen-gtk/2d1e8ce65b81404936cddfe669e3a9b8b03d59ad ok. Committed and backported. Closing. Thanks for reporting ! Confirmed works here, thanks for the quick fix! |