Bug 303830

Summary: Warn if keditbookmarks is not installed
Product: [Applications] keditbookmarks Reporter: Alf <real.aussie>
Component: generalAssignee: Konqueror Bugs <konqueror-bugs-null>
Status: RESOLVED FIXED    
Severity: wishlist CC: cfeck, Eric
Priority: VLO Keywords: junior-jobs
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Ubuntu   
OS: Linux   
Latest Commit: https://commits.kde.org/kbookmarks/8fb63b082cdda6771a4833d0a0cb57886a1647e0 Version Fixed In:
Sentry Crash Report:

Description Alf 2012-07-20 01:08:08 UTC 
Summary says it all really.

When I select "Bookmarks" -> "Edit Bookmarks..." nothing happens.

Reproducible: Always

Steps to Reproduce:
1. Start krdc
2. Select "Bookmarks" from menubar.
3. Select "Edit Bookmarks..." from dropdown.
Actual Results:  
Nothing happens - no dialog, no error, no warning.

Expected Results:  
That a dialog should open allowing me to edit bookmarks.
Comment 1 Christoph Feck 2012-07-20 01:40:05 UTC 
What happens if you run "keditbookmarks" from Konsole?
Comment 2 Alf 2012-07-20 04:38:45 UTC 
2012-07-20 14:36:20 homer@AU-L4A102325HL ~
$ keditbookmarks
The program 'keditbookmarks' is currently not installed.  You can install it by typing:
sudo apt-get install kde-baseapps-bin
2012-07-20 14:36:26 homer@AU-L4A102325HL ~
$ 

I guess that would do it!

So THIS RAISE QUESTIONS 2 & 3:

2: why wan't this reported?
3: why isn't it a dependency in the repository?
Comment 3 Christoph Feck 2012-07-20 10:22:13 UTC 
Please report packaging/dependency issues to the bug tracker of your distribution via https://bugs.launchpad.net/ubuntu
Comment 4 Alf 2012-07-21 00:41:26 UTC 
Thanks, Christoph.  Will do now.
Comment 5 Alf 2012-07-21 00:50:55 UTC 
But that doesn't answer the other question: why doesn't krdc report this error?

krdc should announce "cannot launch kdebase-bin".
Comment 6 Urs Wolfer 2012-12-23 17:22:04 UTC 
The bahavior if keditbookmarks is not installed could be imporoved.

See:  kdelibs/kio/bookmarks/kbookmarkmanager.cc.html
Line: QProcess::startDetached("keditbookmarks", args);
Comment 7 Eric Kincl 2017-04-04 17:18:23 UTC 
It's 2017 and this is still a problem on KDE 5.  (Using the KDE Neon distro at that.)

There isn't even a console error that gets thrown, just... nothing.  I've been ripping my hair out trying to figure out what the problem was and I finally found this buried in Google.  A simple error message would be very beneficial.
Comment 8 Albert Astals Cid 2017-06-25 15:54:53 UTC 
Git commit 8fb63b082cdda6771a4833d0a0cb57886a1647e0 by Albert Astals Cid, on behalf of Valeriy Malov.
Committed on 25/06/2017 at 15:53.
Pushed by aacid into branch 'master'.

Emit errors when keditbookmarks is missing

KBookmarkManager::slotEditBookmarks is supposed to run keditbookmarks,
but does not emit any errors when if it's missing
This makes "Edit bookmarks" menu fail silently in applications that use
KBookmarks (e.g. krdc, konsole)

Differential Revision: https://phabricator.kde.org/D6277

M  +19   -2    src/kbookmarkmanager.cpp
M  +2    -0    src/kbookmarkmanager.h

https://commits.kde.org/kbookmarks/8fb63b082cdda6771a4833d0a0cb57886a1647e0