| Summary: | connection error notification appears of google and facebook telepathy account on startup even though no internet connection exists yet | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] telepathy | Reporter: | Johannes K. <joker777vs.666> |
| Component: | kded-module | Assignee: | Telepathy Bugs <kde-telepathy-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | asturm, kde, mklapetek, stuffcorpse |
| Priority: | NOR | Flags: | kde:
ReviewRequest+
|
| Version: | git-latest | ||
| Target Milestone: | Future | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/telepathy-kded-module/69c307cfded70fd820119b328ab5650e38c22c23 | Version Fixed In: | 0.5.2 |
| Sentry Crash Report: | |||
|
Description
Johannes K.
2012-07-13 21:45:19 UTC
Can you double confirm you're using the git-latest ktp-kded-module? A patch was made after 0.4 which hopefully reduces this issue. Hi David Yes I do. Updated and compiled it yesterday. Thanks for your quick reply. Hi David I just had a look to your commit in ktp-kded-module. According to my error message the case block uses the default case but your if block is only in the Tp::ConnectionStatusReasonNetworkError. Could you explain me how to debug this with gdb? I really would like to know what value the variable "reason" has. Thanks a lot. btw...won't be able to answer you before this evening. Well that error would show (so confirming this bug) Martin, would you be happy if we just suppress _all_ error notifications if the network is down? It would solve this issue, and I can't think of any real-use drawbacks. If we can exclude those errors that are a result of user trying to connect (ie. network is down, user tries to go online), then yes. I'm plagued by the same behaviour since installing an SSD that simply fires up the system too fast for any wireless connection to be ready in time. ;) kde-telepathy 0.5.1 packages and wicd-client here. The fact that you're using wicd is the problem here. Mission-Control (the backend for Telepathy) is network-manager aware not wicd aware..it has no idea if we're online or not - so it will try and connect. KDE is wicd aware (as well as NM) when we get an error from the backends with the proposed patch we will supress it, and not bug the user. (https://git.reviewboard.kde.org/r/107654/) Git commit 7d1013500e22cf5deb362852abaedd852bc08186 by David Edmundson. Committed on 10/12/2012 at 01:20. Pushed by davidedmundson into branch 'kde-telepathy-0.5'. Supress all errors unless we are connected to the network REVIEW: 107654 M +6 -4 error-handler.cpp http://commits.kde.org/telepathy-kded-module/7d1013500e22cf5deb362852abaedd852bc08186 Git commit 69c307cfded70fd820119b328ab5650e38c22c23 by David Edmundson. Committed on 10/12/2012 at 01:20. Pushed by davidedmundson into branch 'master'. Supress all errors unless we are connected to the network REVIEW: 107654 Conflicts: error-handler.cpp M +6 -4 error-handler.cpp http://commits.kde.org/telepathy-kded-module/69c307cfded70fd820119b328ab5650e38c22c23 Marking as fixed, though you may still get popups when the internet connection is dodgy. Such as at an airport or hotel where you are connected but need to sign in to a wi-fi network. |