Bug 303471

Works here (latest master, of course). Can anyone else confirm?

Works for me too..

DrDanz please use the webkit inspect option and see if there's any errors in the console.

Also tell us which theme you're using and which emoticon set. I suspect you're using one with it's own Template.html.

This seems to be broken again in master... icons are no longer changed to text
Marking this as blocking for 0.5.1

It works for me. Must be theme related, at which point this is quite a minor issue.  We can't fix everything if themes ship a broken Template.html file

Could you open the web inspector from the context menu and show us what's in the console?

(also in this context, I don't care about master, only the 0.5 branch)

Ok, I confirm that it is a theme related issue...
Except for Renkoo and SimKete and a limited set of themes, most of the themes I tried either don't swap, or swap correctly to text, but don't swap back to the image (and a question mark image is showed instead)

Actually after trying a few more the set is not that limited...

For themes that don't switch back to the original image, the console gives this kind of error:

Failed to load resource: Error opening //home/drdanz/.kde/share/apps/ktelepathy/styles/Ruler.AdiumMessageStyle/Contents/Resources/undefined: No such file or directory

Failed to load resource: Error opening //home/drdanz/.kde/share/apps/ktelepathy/styles/Mochastyle.AdiumMessageStyle/Contents/Resources/undefined: No such file or directory


For themes that don't switch to the original text there is no error at all.

This is now back to being a non-important bug as it does not affect the defaults we ship.

It is also not a regression. 
I see no reason for this to block any release.

I agree that since it's a theme problem it's not 

Anyway I investigated a little and I found out that the theme that I was using (that is not changing at all) in Footer.html has this:

                //Swap an image with its alt-tag text on click, or expand/unexpand an attached image
                document.onclick = imageCheck;
                function imageCheck() {         
                        node = event.target;
                        if(node.tagName == 'IMG' && !client.zoomImage(node) && node.alt) {
                                a = document.createElement('a');
                                a.setAttribute('onclick', 'imageSwap(this)');
                                a.setAttribute('src', node.getAttribute('src'));
                                a.className = node.className;
                                text = document.createTextNode(node.alt);
                                a.appendChild(text);
                                node.parentNode.replaceChild(a, node);
                        }
                }

                function imageSwap(node) {
                        shouldScroll = nearBottom();

                        //Swap the image/text
                        img = document.createElement('img');
                        img.setAttribute('src', node.getAttribute('src'));
                        img.setAttribute('alt', node.firstChild.nodeValue);
                        img.className = node.className;
                        node.parentNode.replaceChild(img, node);

                        alignChat(shouldScroll);
                }

After deleting this part the emoticons switch correctly.

Should we close this as invalid, since it is a theme problem, or do we want to handle this and find a solution?

> Should we close this as invalid, since it is a theme problem, 

I think so.